Commit graph

52544 commits

Author SHA1 Message Date
Melissa Alvarez
490bee238b
[ML] Anomaly Detection: Adds View in Maps item to Actions menu in the anomalies table (#131284)
* add link to actions menu in anomalies table

* set map start time to bucket start

* simplify isGeoRecord value setting

* lint fix

* adds query and timerange to link

* substract ms so as not to go into next bucket start time

* lint fix
2022-05-04 13:43:54 -06:00
Garrett Spong
683463ea43
[Security Solution][Detections] Rule Execution Log Feedback and Fixes Part Deux (#130072)
## Summary

Addresses feedback and fixes identified in https://github.com/elastic/kibana/pull/126215 & https://github.com/elastic/kibana/pull/129003

##### Feedback addressed includes:
* Adds toast for restoring global query state after performing `view alerts for execution` action
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/164511565-b77d3dc8-a8b5-4927-a947-54966a58c74f.gif" />
</p>

* Updates global SuperDatePicker to daterange of execution (+/- day) for `view alerts for execution` action (and clear all other filters)
  * See above gif
* Remove redundant `RuleExecutionStatusType` (https://github.com/elastic/kibana/pull/129003#discussion_r842924704)
* Persist table state (DatePicker/StatusFilter/SortField/SortOrder/Pagination) when navigating to other tabs on the same page
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/164512498-59416601-d967-4a27-b0cc-0715cc0662c0.gif" />
</p>

* Fix duration hours bug (`7 hours (25033167ms)` as `06:417:13:000`)
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/164511478-bf0bb6d8-d8b7-4c86-8fbd-b60090f00555.png" />
</p> 

* Support `disabled rule` platform error (https://github.com/elastic/kibana/pull/126215#discussion_r834364979)
  * Updated `getAggregateExecutionEvents` to fallback to platform status from `event.outcome` if `security_status` is empty, and also falls back to `error.message` is `security_message` is empty. This also now queries for corresponding `event.outcome` if filter is provided so that platform-only events can still be displayed when filtering.
<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/164510056-1e0bce86-8360-4d46-b591-2041457e3244.png" />
</p>

* Verify StatusFilter issue https://github.com/elastic/kibana/pull/126215#issuecomment-1080976155
  * Unable to reproduce, I believe the query updates around first querying for status may've fixed this?
* Provide helpful defaults for `to`/`from` and support datemath strings again (https://github.com/elastic/kibana/pull/129003#discussion_r843091926)
  * Created enhancement for this here: https://github.com/elastic/kibana/issues/131095
* Adds UI Unit tests for RuleExecutionLog Table
* Finalize API Integration tests for gap remediation events
  * Test methods developed for injecting arbitrary execution events while still working with event-log RBAC. See last [API integration test](22cc0c8dbd/x-pack/test/detection_engine_api_integration/security_and_spaces/tests/get_rule_execution_events.ts (L121-L166)) for technique. This can further be used to inject many execution events and expand tests around pagination, sorting, filters, etc.
* Fixes `gap_duration`'s of `1-499`ms showing up as `-` instead of `0`
* Fixes restore filters action to restore either absolute or relative datepicker as it originally was
* Resolves https://github.com/elastic/kibana/issues/130946
  * Adds `min-height` to tab container
  * Removes scroll-pane from ExceptionsViewer to match Alerts/Execution Log
---

##### Remaining follow-ups:

None! 🎉 






### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
2022-05-04 13:22:18 -06:00
Ying Mao
2dcbcb45d1
[Response Ops][Docs] Alerting circuit breaker docs (#131459)
* Circuit breaker docs

* Apply suggestions from code review

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2022-05-04 15:04:25 -04:00
Kristof C
c43a51d7ab
[Security Solution][Detection & Response] 131028 implement recently opened cases table (#131029)
* First draft at possible implementation. tests need to be added, and imports,comments, logs cleaned up

* Further tweaks to alerts counters

* Add tests for alerts_counters hook

* Working on vulnerable hosts

* Add useVulnerableHostsCounters hook along with tests

* add Vulnerable users and tests

* Move files to components folder and wire up to detections overview page

* Add translations

* add querytoggle and navigation to both tables

* fix bug for toggleQuery

* update button navigation

* remove alerts by status, as Angela built instead

* Working on changing test files

* test files for host and user hooks complete

* Components complete

* bug fixes from PR

* failing tests

* Undo bad edit to useRuleAlerts test

* Fix show inspect on hover, and use HostDetailsLink component

* missed in last commit

* more fixes from PR review

* recent cases table working, need tests

* first pass for table and data fetching

* Make changes from PR review

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* PR fixes

* PR fixes

* remove cases api date workaround

* enable detectionsResponse for deployed instance

* Fix tests

* turn off detectionresponseEnabled flag

* fixes from design review

* stability fix. remove useUserInfo

* Add comment for removing togglequery code

Co-authored-by: Kristof-Pierre Cummings <kristofpierre.cummings@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-05-04 11:56:00 -07:00
Quynh Nguyen
a632484214
[ML] Add recognized modules links for Index data visualizer (#131342)
* [ML] Add dynamic registration of links for both index and file

* [ML] Consolidate type imports

* [ML] Revert uptime changes

* [ML] Fix cards visible when canDisplay is false

* [ML] Shorten create job text

* [ML] Remove as assertions

* [ML] Rename to GetAdditionalLinks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-05-04 11:21:51 -07:00
Chris Roberson
fe76adbc3a
[ResponseOps] Fix broken search strategy test (#130393)
* Unskip and add debug

* try this

* lets fail

* this?

* add another

* Add more

* Try this

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-05-04 14:21:21 -04:00
Spencer
1cdf0a45a6
[ci] hide browserslist outdated warnings (#131549) 2022-05-04 13:04:40 -05:00
mgiota
47f4658b36
[Actionable Observability] consume shareable status filter (#131219)
* use shareable status filter

* clean up and remove remnants from old status implementation

* bring back props

* fix more CI issues after renaming

* fix i118n issues

* fix failing unit tests
2022-05-04 19:57:32 +02:00
spalger
1c99a04c04 skip flaky suite (#131535) 2022-05-04 12:45:05 -05:00
Jonathan Budzenski
2288342143
Bump versions.json (#131545) 2022-05-04 10:34:22 -07:00
Spencer
1a849dc2b6
[flaky-tests] require using the new UI to trigger (#131534) 2022-05-04 09:52:34 -07:00
Gabriel Landau
486bf6d50a
Add some missing Endpoint telemetry fields (#131529)
* Add some missing Endpoint telemetry fields

* Update test case

* Fix syntax

* Get all of process.pe

* lint

* Add more token and DLL fields

* Alphabetical

* Add
2022-05-04 12:48:05 -04:00
Abdul Wahab Zahid
57fc34e595
[Synthetics] Create empty state and routes (#131431) 2022-05-04 18:39:02 +02:00
Alejandro Fernández Haro
7226982759
[EBT] Add Elastic V3 Shippers (#130696)
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-05-04 09:22:34 -07:00
spalger
143fe7f6e7 skip suite blocking es promotion (#125033) 2022-05-04 11:21:35 -05:00
Eric Davis
f4d558a6da
[DOCS] Update details about alert visibility in Stack Management (#130202)
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2022-05-04 12:19:25 -04:00
Yara Tercero
29705c01e4
[Security Solution][Legacy Actions] - Update legacy action migration to account for more edge cases (#130511)
## Summary

Updates the legacy actions migration code to account for edge cases we had not initially caught. Thanks to testing from some teammates, they reported seeing the following behavior:

- Rules created pre 7.16 with no actions still create the legacy action sidecar (but not a `siem.notifications` legacy actions alert) which upon migration to 7.16+ was not being deleted
- Rules created pre 7.16 with actions that run on every rule run create the legacy action sidecar(but not a `siem.notifications` legacy actions alert) which upon migration to 7.16+ was not being deleted
- Rules created pre 7.16 with actions that were never enabled until 8.x did not have a `siem.notifications` legacy actions alert type created

Because the legacy migration code relied on checking if a corresponding `siem.notifications` SO existed to kick off the necessary cleanup/migration, the above edge cases  were not being caught.
2022-05-04 08:45:24 -07:00
Xavier Mouligneau
956612d071
[RAM] Bug api find/index alerts (#131338)
* fix bug

* fix unit test

* bing back tests alive after a long CPR

* fix test and bring back recursive aggs

* I need to do an intersectiona and not union

* fix last integration test
2022-05-04 11:18:05 -04:00
Alejandro Fernández Haro
5f06375fe6
[FullStory] Document browser exposed config in the test (#131527) 2022-05-04 08:15:33 -07:00
Paulo Henrique
94b87e71e9
[Session View] Alert UI Fixes (#131356)
* adding missing color to use eui theme hook

* button and spacing refactor

* updating colors and spacing on alerts

* adding custom components for nbsp and split text

* updating test to match nbsp instead of white space

* update process tree node to match design spec
2022-05-04 12:01:24 -03:00
Gayathri R
4f88950bde
[APM] ellipsis truncation issue - dependencies and service section (#122203)
* Added ellipsis truncation to apm dependency

* Added ellipsis truncation to apm service

* Removed un-used variable

* Added ellipsis truncation

* removing unused import

* modified css classname

* created a new component for truncation without tooltip

* using text truncate styling and removed truncatewithouttooltip component

* restored styledlink
2022-05-04 07:43:11 -07:00
Cauê Marcondes
0c96914837
[APM] Fixing service overview test (#131454)
* skipping flaky test

* Fix environment suggestion test

* removing comment

Co-authored-by: Kate Patticha <aikaterini.patticha@elastic.co>
2022-05-04 07:41:26 -07:00
Bhavya RM
81161c26ac
Fixing test data for import and export between versions tests (#131470) 2022-05-04 09:58:19 -04:00
Matthew Kime
dc529800ad
passing default selection enables selection. boo (#131473) 2022-05-04 07:19:10 -05:00
Christos Nasikas
8dd22dd023
[Cases] Export getCasesMetrics from the cases UI client (#131493)
* Export cases metrics

* Fixes

* Add integration tests

* Add comment

* Add signal
2022-05-04 05:12:04 -07:00
Tomasz Ciecierski
dda625c933
[Osquery] Add logo (#131060) 2022-05-04 13:48:13 +02:00
Alejandro Fernández Haro
8271455691
[EBT] Remove unnecessary async from tests (#131500) 2022-05-04 04:44:16 -07:00
CohenIdo
876d65c479
[Cloud Security] add rules status to benchmark API 2022-05-04 14:43:36 +03:00
Martijn Laarman
71a1f04703
Fixes worker silent failure after style violations fixes (#131415) 2022-05-04 13:37:25 +02:00
Katerina Patticha
dbb4d3cf2c
[APM] Rename service groups template titles and links (#131381)
* [APM] Update template title for service groups

* [APM] Update link titles in global search

* Fix translations

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-05-04 13:22:04 +02:00
Oren Zohar
a1f8cd4ac0
updating managed agent manifest needed resources for cloudbeat (#130886) 2022-05-04 14:13:34 +03:00
Alejandro Fernández Haro
13c928d4f3
[FullStory] Filter custom events by an allowlist (#131148) 2022-05-04 13:08:25 +02:00
David Sánchez
df225b213b
[Security Solution] [Endpoint] Update blocklist flyout license banner copy (#130561)
* Add missing period at the end of the sentence

* Copy update due old pr comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-05-04 12:41:00 +02:00
Alejandro Fernández Haro
c9b424c8a2
[EBT] Fix flaky test (#131494) 2022-05-04 12:32:18 +02:00
Anton Dosov
9aeb1fb446
Update search session config docs (#131411) 2022-05-04 11:58:01 +02:00
Matthias Wilhelm
c9d84e32f2
[Discover] Migrate legacy searchSource fetch() to fetch$() (#129104) 2022-05-04 11:47:56 +02:00
Matthias Wilhelm
5793d1949f
[Discover] Add project tree to README.md (#131480) 2022-05-04 11:30:39 +02:00
Pablo Machado
78d6acef24
Create Manage landing page (#131245)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-05-04 02:19:49 -07:00
Christos Nasikas
07c8da05c2
[Cases] Fix find method of the cases UI client. (#131407) 2022-05-04 12:00:16 +03:00
CohenIdo
41c629639b
[Cloud Security] fetch all rules templates 2022-05-04 11:58:19 +03:00
Joe Reuter
f30919ce54
[Vega] Adjust vega doc for usage of ems files (#130948)
* adjust vega doc

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Nick Peihl <nickpeihl@gmail.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nick Peihl <nickpeihl@gmail.com>
2022-05-04 04:02:54 -04:00
Joe Reuter
f2f90ba9fd
[Lens] Improved interval input (#131372) 2022-05-04 09:53:08 +02:00
Alejandro Fernández Gómez
b7d42ea04c
[Unified observability] Add tour step to guided setup (#131149) 2022-05-04 09:23:37 +02:00
Christiane (Tina) Heiligers
4b19c72dde
Improve saved objects migrations failure errors and logs (#131359) 2022-05-03 18:03:48 -07:00
Clint Andrew Hall
01e12ec1d6
[storybook] Watch for changes in packages (#131467)
* [storybook] Watch for changes in packages

* Update default_config.ts
2022-05-03 16:24:22 -07:00
Jiawei Wu
07985db97a
[RAM] Add shareable rule status filter (#130705)
* rule state filter

* turn off experiment

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Status filter API call

* Fix tests

* rename state to status, added tests

* Address comments and fix tests

* Revert experiment flag

* Remove unused translations

* Addressed comments

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-05-03 15:57:25 -07:00
mgiota
28092ef609
[Actionable Observability] Add license modal to rules table (#131232)
* Add fix license link

* fix localization

* fix CI error

* fix more translation issues

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-05-03 15:27:09 -06:00
Brian Seeders
3bc9c42485
[CI] Use GCS buckets for bazel remote caching (#131345) 2022-05-03 16:49:37 -04:00
Thomas Neirynck
3a482f175a
Update API docs (#130999)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-05-03 16:13:19 -04:00
Bhavya RM
02c21aa1e2
Adding aria-label for discover data grid select document checkbox (#131277) 2022-05-03 15:37:23 -04:00