Commit graph

66130 commits

Author SHA1 Message Date
Patryk Kopyciński
75d351052d
It adds 8.10 into the .backportrc config file (#164259)
## Summary

It adds 8.10 into the .backportrc config file

Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
2023-08-21 15:15:30 +01:00
Kevin Logan
88bd71c077
[Security Solution] File paths for Blocklist Windows and Mac should be case insensitive (#164200)
## Summary

This fixes a bug where Windows and Mac Blocklist file path entries
should be passed as case insensitive. This is because Mac and Windows
are caseless for most use cases.

Bug ticket: https://github.com/elastic/kibana/issues/158581

Here is how it will be displayed in the UI:
<img width="1728" alt="image"
src="a3006397-f49e-4de0-818d-94e2de20dba3">

Here are the breakdown of the artifacts after the fix:

Linux:
```
-------------------------------------------------------------------
Policy:   Protect
Manifest: 1.0.6 | v1
Artifact: endpoint-blocklist-linux-v1
          Relative URL:   /api/fleet/artifacts/endpoint-blocklist-linux-v1/f33e6890aeced00861c26a08121dd42d2d29ba08abfeb3c065d0447e32e18640
          Encoded SHA256: a907835be40af89b8b7aa23a6efc66c01ceaa5a19622edd378139319f3ca5fa0
          Decoded SHA256: f33e6890aeced00861c26a08121dd42d2d29ba08abfeb3c065d0447e32e18640
-------------------------------------------------------------------

{
  "entries": [
    {
      "type": "simple",
      "entries": [
        {
          "field": "file.path",
          "operator": "included",
          "type": "exact_cased_any",
          "value": [
            "/opt/bin/bin.exe"
          ]
        }
      ]
    }
  ]
}
```

Mac:
```
-------------------------------------------------------------------
Policy:   Protect
Manifest: 1.0.6 | v1
Artifact: endpoint-blocklist-macos-v1
          Relative URL:   /api/fleet/artifacts/endpoint-blocklist-macos-v1/b28e7978da4314ebc2c94770e0638fc4b2270f9dc17a11d6d32b8634b1fbec0f
          Encoded SHA256: 4f3e80d688f5cae4bf6a88b0704e37909f9fa4f47fe8325b7b154cddd46a2db9
          Decoded SHA256: b28e7978da4314ebc2c94770e0638fc4b2270f9dc17a11d6d32b8634b1fbec0f
-------------------------------------------------------------------

{
  "entries": [
    {
      "type": "simple",
      "entries": [
        {
          "field": "file.path",
          "operator": "included",
          "type": "exact_caseless_any",
          "value": [
            "/opt/exe.exe"
          ]
        }
      ]
    }
```

Windows:
```
-------------------------------------------------------------------
Policy:   Protect
Manifest: 1.0.6 | v1
Artifact: endpoint-blocklist-windows-v1
          Relative URL:   /api/fleet/artifacts/endpoint-blocklist-windows-v1/2a6fcc67c696ad4e29d91f8b685bff46977198cd34b9a61e8003d55b78dff6ac
          Encoded SHA256: c6e045fce97651336eeb400f0123541475b940e3aa38ce721f299585683da288
          Decoded SHA256: 2a6fcc67c696ad4e29d91f8b685bff46977198cd34b9a61e8003d55b78dff6ac
-------------------------------------------------------------------

{
  "entries": [
    {
      "type": "simple",
      "entries": [
        {
          "field": "file.path",
          "operator": "included",
          "type": "exact_caseless_any",
          "value": [
            "C:\\path\\path.exe"
          ]
        }
      ]
    }
  ]
}
```

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-08-21 10:00:53 -04:00
Devon Thomson
011ae97061
[Dashboard] Remove clone by reference (#164108)
Removes all clone by reference functionality on the Dashboard. This means that we no longer have any `savedObjectsClient` usage in the browser side.
2023-08-21 09:51:07 -04:00
amyjtechwriter
90b6e4dbe0
[DOCS] Removes 8.9.1 coming tag. (#164302)
Removes `coming` tag from the 8.9.1 release notes.
2023-08-21 14:24:48 +01:00
Marco Liberati
dbb252b02a
[Lens] Reduce the impact of TSDB downsample bug (#164183)
## Summary

Fixes #163971 

Reduces the impact of the ES promotion issue coming from the ES TSDB
downsampling bug to only downsampling tests and not the entire TSDB
suite.


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2023-08-21 15:01:01 +02:00
Søren Louv-Jansen
ebe6b4650a
[APM] Remove power_user and read_only_user folders from e2e (#164242)
We currently separate e2e tests into `power_user` tests and
`read_only_user` tests. We often want to test different permissions
within the same tests, so the distinction becomes a barrier rather than
a help. This PR removed the folders and combines all tests regardless of
which user they run as.
2023-08-21 14:51:28 +02:00
Stratoula Kalafateli
00102e33f3
[Sample data][ECommerce] Use Lens instead of TSVB (#164195)
## Summary

Closes https://github.com/elastic/kibana/issues/164146

Changes the remaining TSVB panel to a by value Lens metric.
<img width="1652" alt="Screenshot 2023-08-17 at 6 10 06 PM"
src="538b4bfb-5066-4a93-a16c-4d748b29ea7c">

### How to test
Remove the ecommerce dataset and reinstall it
2023-08-21 13:12:09 +01:00
amyjtechwriter
037cbce707
[OAS] Adding update and delete to runtime fields OAS (#163777)
This PR drafts openAPI specifications for:

- [Delete runtime field
API](https://www.elastic.co/guide/en/kibana/master/data-views-runtime-field-api-delete.html).
- [Update runtime field
API](https://www.elastic.co/guide/en/kibana/master/data-views-runtime-field-api-update.html)

Relates to https://github.com/elastic/kibana/issues/137240
2023-08-21 12:41:22 +01:00
Jean-Louis Leysens
23d39555e0
[HTTP] Allow for internal requests to also specify special query param elasticInternalOrigin (#163796)
## Summary

Closes https://github.com/elastic/kibana/issues/163678

* Raise the notion of "internal" into `CoreKibanaRequest`. This enables
us to share this with lifecycle handlers and control validation of query
params
* Added new `isInternalRequest` alongside `isSystemRequest` and
`isFakeRequest`
* Slight simplification to existing internal restriction check
* Some other chores and minor fixes

## Test

* Start ES with `yarn es serverless` and Kibana with `yarn start
--serverless --server.restrictInternalApis=true`
* Add the service account token to `kibana.dev.yml`:
`elasticsearch.serviceAccountToken: <SAT>`
* Send a request to an internal endpoint like: `curl -XPOST
-uelastic:changeme http://localhost:5601/<base-path>/api/files/find -H
'kbn-xsrf: foo' -H 'content-type: application/json' -d '{}'`
    * Should give you a 400 result
* message like `{"statusCode":400,"error":"Bad Request","message":"uri
[http://localhost:5603/api/files/find] with method [post] exists but is
not available with the current configuration"}`
* Send the same request, but include the query param:
`elasticInternalOrigin=true`
   *  Should give you a 200 result

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-08-21 11:55:33 +02:00
David Sánchez
bc988f22c6
[Security Solution] [Endpoint] Generate empty endpoint user artifacts depending on the PLI (#163602)
## Summary

Generates empty array when the PLI don't meet the requirement. It end up
having empty fleet artifacts for those cannot be generated.

It also adds new test cases

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-08-21 11:30:06 +02:00
Or Ouziel
81a151ef71
[Cloud Security] Only clean up AWS creds (#164154) 2023-08-21 12:23:15 +03:00
Sander Philipse
8532b996c4
[Search] Disable crawler on overview without ent-search (#164227)
## Summary

This disables the crawler if Enterprise Search is not available on the
new overview page.
2023-08-21 10:37:59 +02:00
Tim Sullivan
f1402d682c
unskip sample_data_apis test: dates (#164112)
## Summary

Closes https://github.com/elastic/kibana/issues/121051

I'm not seeing flakiness in the test suite after enabling all the tests.

Test suite: `test/api_integration/config.js`
Test runs:
*
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2904
*
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2917
2023-08-18 16:44:21 -07:00
Patryk Kopyciński
7c5392ba22
[osquery] Update E2E to not install Osquery integration on the Fleet server (#164225)
## Summary

Increase the stability of Osquery Cypress by stopping the installation
of Osquery on the Fleet server and creating another Agent policy and
enrolling another elastic agent instead
2023-08-18 21:01:59 +02:00
Quynh Nguyen (Quinn)
5cfb693701
[ML] Fix query bar not switching from KQL to Lucene and vice versa in Anomaly explorer (#163625) 2023-08-18 09:52:25 -07:00
Kibana Machine
2b3048f96a
[api-docs] 2023-08-18 Daily api_docs build (#164241)
Generated by
https://buildkite.com/elastic/kibana-api-docs-daily/builds/433
2023-08-18 00:58:24 -04:00
Nathan Reese
53e803e42c
fix 'Download CSV' returns no data when panel has custom time range outside timerange of global time picker (#163887)
Closes https://github.com/elastic/kibana/issues/163614

PR resolves issue by only adding global time filter to CSV export body
when saved search embeddable does not have time range.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-08-17 16:37:12 -06:00
Karl Godard
7127d32e34
[Automated PR] Sync cloud_defend plugin policy schema with cloud-defend repo (#164216)
Automated by https://buildkite.com/elastic/cloud-defend/builds/2061

Co-authored-by: sec_cloudnative_integrations <sec-cloudnative-integrations@elastic.co>
2023-08-17 15:31:20 -07:00
Lisa Cawley
5c1d118c36
[OAS] Add is_system_action to connector responses (#163969) 2023-08-17 13:13:35 -07:00
Catherine Liu
3720270232
[Dashboard] Add filter details to panel settings (#162913) 2023-08-17 12:36:10 -07:00
Tiago Costa
db1cec4c94
skip flaky suite (#164164) 2023-08-17 19:58:27 +01:00
Tiago Costa
c48b74a693
chore(NA): update versions after v8.9.2 bump (#164193)
This PR is a simple update of our versions file after the recent bumps.
2023-08-17 19:51:23 +01:00
Julia Rechkunova
110449df5c
[OnWeek][Discover] Allow to fetch more documents on Discover page (#163784)
> [!WARNING]
> Sorry, I had to recreate the PR
https://github.com/elastic/kibana/pull/157241
> Please submit your review again.

- Closes https://github.com/elastic/kibana/issues/155019

Per docs
https://www.elastic.co/guide/en/elasticsearch/reference/current/paginate-search-results.html
<img width="851" alt="Screenshot 2023-05-10 at 10 25 20"
src="b4b9fef4-7dd8-40ed-8244-343889fc4367">


## Summary

1. This PR improves `search_after` pagination for `date_nanos` time
fields. `sort` value will be returned from ES as a string instead of a
rounded and incorrect timestamp. This change allows to also simplify
logic on Surrounding document page.

Before:
<img width="400" alt="Screenshot 2023-05-08 at 17 36 19"
src="fd9f45c4-5dc2-4103-83b9-8810e3a6e0df">

After:
<img width="400" alt="Screenshot 2023-05-08 at 17 37 13"
src="fe9090c0-2116-4f77-9a57-a96ae6b00365">

2. Also in this PR we now allow users to load more documents within the
same time range. Once the button is pressed, it will load next portion
of documents (same "sampleSize" value will be used). Currently, we limit
max total loaded documents to 10000.

"Load more" demo:
![Aug-07-2023
16-23-28](53af9809-75cb-4b8a-8e99-d8f6d76b4981)

If refresh interval is on, the button becomes disabled:
![Aug-07-2023
16-24-58](85db6144-98eb-40b5-ac88-80ea728bcd6b)

Date nanos demo:
![Aug-07-2023
16-34-59](dc9fe0b1-e419-4c76-9fc6-79907b134e58)


100x Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2801

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-08-17 20:31:21 +02:00
GitStart
8ffbc7164d
[Console] Migrate all usages of EuiPage*_Deprecated (#163138) 2023-08-17 14:02:58 -04:00
GitStart
1ab6a4cb26
[CCR] Migrate all usages of EuiPage*_Deprecated (#163135) 2023-08-17 13:40:18 -04:00
Karl Godard
4ce54648f8
[Cloud Security] removed beta label from tty setting (#164122)
## Summary

Removes a beta label from the "terminal output" feature in the linux
settings for the endpoint integration. The beta tag was previously
removed from the TTY player itself, but this spot was missed.

Also, this PR changes codeowners of session_view, kubernetes_security
and cloud_defend plugins to the **kibana-cloud-security-posture** team

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-08-17 10:15:32 -07:00
Dima Arnautov
24baf38eaa
[ML] Fix Trained models list crashes on browser refresh if not on page 1 (#164163)
## Summary

Fixes https://github.com/elastic/kibana/issues/162618

There was an issue with setting pagination for the EUI table before
models are fetched. Providing a page index while the items count is 0
caused pagination to reset with an uninitialized URL state callback.
This PR adds a check to verify model list has been retrieved.

Also, the Kibana `_stats` endpoint has been updated to provide a `size`
parameter.
2023-08-17 09:55:33 -07:00
Tiago Costa
0a331f1023
chore(NA): upgrade typescript-eslint packages to v5.62.0 (#164117)
After https://github.com/elastic/kibana/pull/163895 this PR forward
ports the typescript-eslint packages to v5.62.0.
2023-08-17 17:08:40 +01:00
Patryk Kopyciński
aaedb2d449
[security_solution] Update serverless buildkite pipeline (#164155)
## Summary

Align buildkite pipelines between ess and serverless
2023-08-17 17:41:09 +02:00
Mark Hopkin
c822993c14
[Fleet][API] Add ability to set a proxy for agent download source (#164078)
## Summary

Note: this is only the API changes, the UI element will follow.

Part of #162862 

Add the ability to specify a `proxy_id` on a download source. 

If an agent policy uses a download source with a `proxy_id`, then the
proxy url will be added to the policy like so:
`agent.download.proxy_url: <proxy_url>`.

Test cases automated:
- create a download source with a valid proxy_id
- create a download source with an invalid proxy_id
- update download wource proxy_id
- update download_source proxy_id to null (remove proxy)
- updating a download source proxy bumps all policies using that
download source
- removing a download source proxy bumps all policies using that
download source
- updating the proxy url bumps all policies using a download source with
the proxy id set
- deleting the proxy bumps all policies using a download source with the
proxy id set to remove the proxy

### Checklist

Delete any items that are not applicable to this PR.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-08-17 16:38:55 +01:00
Julia Rechkunova
63da51dc66
[Discover] Split a drag & drop test into 2 tests (#164149)
- Closes https://github.com/elastic/kibana/issues/163979
- Closes https://github.com/elastic/kibana/issues/163980

It was adding both fields too fast.
100x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2908
2023-08-17 16:57:59 +02:00
Marius Dragomir
33c35a5acd
[QA] Dismiss telemetry banner in ccs console test (#164178)
## Summary

Removing the telemetry banner during the CCS console test will help with
flakiness (allowing for more of the query result to be in the view
port).
2023-08-17 07:57:13 -07:00
Achyut Jhunjhunwala
b7e009a6fc
[APM] Fix 401 issue with Serverless tests for APM (#164162)
## Summary

Fix credential issues for running serverless tests for APM against MKI
2023-08-17 16:47:27 +02:00
Drew Tate
276cf86858
[Event annotations] add types to integration tests (#164103) 2023-08-17 09:17:25 -05:00
Vadim Kibana
3d60f22a92
Eui deprecations 5 (#164106)
## Summary

Partially addresses https://github.com/elastic/kibana/issues/161422
2023-08-17 15:58:36 +02:00
Vadim Kibana
2f79a62d22
update deprecated eui components in reportin_example plugin (#164071)
## Summary

Partially addresses https://github.com/elastic/kibana/issues/161422

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-08-17 15:57:23 +02:00
Kerry Gallagher
a96785cd2c
[Logs] Amend lazy imports in logs_shared plugin (#164102)
## Summary

As part of https://github.com/elastic/kibana/pull/161151 a [selection of
component imports were made
lazy](https://github.com/elastic/kibana/blob/main/x-pack/plugins/logs_shared/public/index.ts#L52)
and wrapped with a [`dynamic` wrapper
component](https://github.com/elastic/kibana/blob/main/x-pack/plugins/logs_shared/common/dynamic.tsx#L22).
Unfortunately some of these imports did not adhere to the rules of
React's `lazy` imports (needing a `default` export, no named imports
etc), and the `dynamic` wrapper seems to have suppressed error
information that would have been available via using `lazy` directly.

Only the anomaly and categories log entry examples (in the expanded
rows) were affected by this, as the stream and embeddable import from
locations that were backed by a `default` export (and those top level
components don't import from that particular index file lower in the
hierarchy). For imports that weren't backed by a `default` I've added
them, and where necessary moved components to new files if needed (since
it's one `default` per file).

Also open to suggestions of ways we can alter the `<dynamic />`
component and maintain the error safety 🤔

## Examples

Without these changes:

![Screenshot 2023-08-16 at 17 35
50](78aa0300-109e-40b5-b64f-6574a547cbf3)

Warning using `lazy` directly without the `dynamic` wrapper:

![Screenshot 2023-08-16 at 17 36
27](a71e3c72-cf3a-4846-9ee9-df70c1729b03)

## Testing

- Check all instances render correctly (stream, embeddable uses, and ML
page log entry examples).
2023-08-17 14:44:57 +01:00
Tiago Costa
a5cceb3747
skip flaky suite (#158408) 2023-08-17 14:34:47 +01:00
Davis McPhee
ef79f8b1b9
[Saved Search] [Embeddable] Fix extra fetch in saved search embeddable when custom title is used (#164004)
## Summary

This PR fixes an issue where using a custom title in the saved search
embeddable creates a race condition that could result in an extra fetch
being triggered. I've also created a separate PR with the same changes
that runs the flaky tests 100x each to confirm this fix resolves the
flakiness: #164088.

Resolves #162997.
Resolves #164125.

### Checklist

- [ ] ~Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~
- [ ]
~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] ~Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard
accessibility](https://webaim.org/techniques/keyboard/))~
- [ ] ~Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~
- [ ] ~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
- [ ] ~This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~
- [ ] ~This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2023-08-17 10:28:35 -03:00
Marco Liberati
8bf8df3bf3
[TSVB2Lens] Fix params._interval conversion to Lens formula (#164150)
## Summary

Fix #164148 

This PR changes the target Lens formula function for the TSVB
`params._interval` conversion.


![_interval_conversion](537044b7-63d1-4880-8fd0-250a29416d8f)


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)


### Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.

When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:

| Risk | Probability | Severity | Mitigation/Notes |

|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes&mdash;Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2023-08-17 15:17:00 +02:00
Kevin Logan
cb444bc319
[Security Solution] Reputation service on by default if a cloud deployment (#163836)
## Summary

The reputation service Policy option should be `true` by default if it
is a cloud deployment. Otherwise it should be `false`. This PR corrects
the default option for new policies if it is a cloud deployment.

The migrated Policies should still always default to `false` (already
implemented in a previous PR)

New Policy with `cloud: true`

![image](3f33375b-3bbb-4e3c-be2f-ebe489fcf0d1)

New Policy with `cloud: false`

![image](82c0df3b-ce93-412f-89c6-c26b54eff8dd)

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-08-17 05:45:27 -07:00
Jedrzej Blaszyk
6d076ee5b1
[Enterprise Search] Add missing RCFs for SPO native connector (#164158)
## Summary

Relates to:
https://github.com/elastic/enterprise-search-team/issues/5631

Add missing configuration fields for SPO native connector. Reference to
the source of truth connector configuration:
https://github.com/elastic/connectors-python/blob/main/connectors/sources/sharepoint_online.py#L1143

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
2023-08-17 14:39:28 +02:00
Yngrid Coello
0f8679e3f2
[APM] reenabling api test for last agent version (#164145)
Closes https://github.com/elastic/kibana/issues/161853.
2023-08-17 14:36:30 +02:00
Kevin Lacabane
a67f7f5b16
[asset manager] merge obsasset signals collection (#162222)
## Summary
Closes https://github.com/elastic/kibana/issues/161887

Merges most of the functionality from `feat/obs-asset-manager-demo`
branch. We remove implicit collection code while including:
- asset collectors from signals (also include pods and containers but we
don't use then directly)
- source configuration code (assets or signals)
- `assetAccessor` logic that determines which indices to query

The change also enables ftr test suite. We'll also merge the services
endpoint https://github.com/elastic/kibana/pull/160294 when approved.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jason Rhodes <jason.rhodes@elastic.co>
2023-08-17 13:47:51 +02:00
Julia
b3122cb656
[RAM] add maintenance window banner (#163516)
## Summary

Solves: https://github.com/elastic/kibana/issues/163465

Add maintenance window banner to Rules list and Alerts list in O11y and
Management.

<img width="1334" alt="Screenshot 2023-08-09 at 13 03 50"
src="de0708b1-db2a-4517-91aa-a3d6b3e62b44">

<img width="1350" alt="Screenshot 2023-08-09 at 13 05 10"
src="9f7c488d-e992-4807-a60e-3c077b623b4e">

---------

Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-08-17 04:04:56 -07:00
Ersin Erdal
9079b1c60b
Enable requeue_invalid_tasks config for functional tests (#163768)
Makes isSystemAction field in RawConnector optional and enables
`requeue_invalid_tasks` config for functional tests.
2023-08-17 13:53:02 +03:00
Janki Salvi
18d28fc42c
[Cases] Add max alerts per case to docs (#164141)
## Summary

Added docs for total alerts per case guardrails as per
https://github.com/elastic/kibana/issues/146945

| Description  | Limit | Done? | Documented? | UI?
| ------------- | ---- | :---: | ---- | :----: |
| Total alerts per case   |  1.000  |  | Yes | N/A |
2023-08-17 12:48:30 +02:00
Dzmitry Lemechko
15b118c724
[Lens] add performance journey to track rendering time for XY visualization and suggestions panel (#163412)
## Summary

Related to #163089

Adding the first performance journey for the Lens Editor. It simulated
loading existing Lens visualisation with data view having 10k fields.

We collect the following metrics:
- `fetchFieldsExistenceInfo` reports time it takes to fetch fields in
Data Panel
- `lensVisualizationRenderTime` reports both time it takes to fetch the
data (`time_to_data`) and render the main visualization
(`time_to_render`)
- `lensSuggestionsRenderTime` reports time it takes to render
suggestions panel

Metrics consistency

<img width="568" alt="image"
src="3384bb8e-6152-4bae-93dc-4f7f4167ed07">

Run locally with 
```
node scripts/functional_tests --config x-pack/performance/journeys/many_fields_lens_editor.ts
```

Metrics will be available here 

dd0473ac-826f-5621-9a10-25319700326e?_g=h@61c5ac8

---------

Co-authored-by: Drew Tate <drewctate@gmail.com>
2023-08-17 12:01:03 +02:00
Mykola Harmash
c8083dd676
[Infra UI] Fix filter popovers not being closed on trigger button click (#164060)
Fixes #96534 

## Summary

Fixes the bug with some popovers are not closed if their trigger buttons
are clicked

*Bug demos from the original issue*
Inventory:

![](https://user-images.githubusercontent.com/4104278/113987390-a222e900-984e-11eb-872b-f12f5abe4540.gif)
Metrics Explorer

![](https://user-images.githubusercontent.com/4104278/113988929-3b9eca80-9850-11eb-859a-c639b89af8a5.gif)

### How to test

* Checkout the branch locally
* Goto "Inventory" section
* Click on "Hosts" filter
* Make sure popover opens
* Click on "Hosts" again
* Make sure the popover closes
* Check the same for "Sort by" filter
* Check the same for chart "Actions"  in "Metrics Explorer"
2023-08-17 11:05:32 +02:00
Ievgen Sorokopud
a50b330323
[Security Solution] formatAlertForNotificationActions fails to merge dot and object notations correctly (#164075)
## Summary

Original ticket: #163844

These changes fix the issue with the incorrect `expandDottedObject`
functionality which instead of merging objects would replace with the
latest version of it.
2023-08-17 10:39:24 +02:00