Resolves https://github.com/elastic/kibana/issues/153769
In this PR, I'm making `config`, `secrets` and `params` require a
validation in their connector type definition. Even in scenarios no
values are used, an empty object validation is required. This prevents
arbitrary data from being passed through.
Only `ES Index`, `Server Log` and `Teams` had some empty validators.
Adding them won't be a breaking change because the HTTP API defaults
missing `config` and `secrets` to `{}` ([see
here](https://github.com/elastic/kibana/blob/main/x-pack/plugins/actions/server/routes/create.ts#L19-L24)).
---------
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Below features should be added to Alert Page Filters.(Fixes#154044)
- Design Feedback
- Remove `Save Controls` from Context Menu ( Overflow Menu )
|Before|After|
|:---:|:---:|
||
- Move `Discard Changes -> Context Menu`.
|Before|After|
|:---:|:---:|
||
- When Redirected, do not enter in the Edit Mode and give option of
Saving/Discarding changes to the user in the Callout itself.
|Before|After|
|:---:|:---:|
||
- Functionality Feedback
- Status should always be part of page filters. User should not be able
to remove it.
- Currently users have ability to delete all controls, to persist some
pre-defined controls, but whenever users delete those, we add them back
when users save the controls.
|Before|After|
|:---:|:---:|
| <video
src="https://user-images.githubusercontent.com/7485038/230329833-1dd698d8-6bae-42f9-9133-168b2789f5ff.mov"/>
|<video
src="https://user-images.githubusercontent.com/7485038/230331343-e372da0a-dcd6-4d9d-a5f7-491b78c72998.mov"
/>|
- Raised the issue with `kibana-presentation` team to disabled `delete`
action for a particular controls.
https://github.com/elastic/kibana/issues/154068
Adds inputs for `EuiSelect` and `EuiRadioGroup` for connector
configurations.
- Use if connector type is `dropdown`
- `EuiRadioGroup` if 3 or less options
- `EuiSelect` if 4 or more options
- Extracts field type creation to new react component
`ConnectorConfigurationField`.
- Adds the following configurable field input types:
- textbox
- numeric
- switch (boolean)
- Updates the `ConfigEntry` type to have more field properties
- Replaces `isPasswordValue` with configurable field property
`sensitive`
- Updates field properties for native connectors (MySQL and MongoDB)
Adding `startTrainedModelDeployment`, `stopTrainedModelDeployment`,
`inferTrainedModel`, `updateTrainedModelDeployment` and
`deleteTrainedModel` functions to our shared services so other plugins
can use them.
## Summary
Update the versioned router based on current Elastic API spec.
Laundry list of changes:
1. Public versions must be specified as `^[0-9]{4}-[0-9]{2}-[0-9]{2}$`
e.g. 2023-12-12
2. For unsupported versions we respond with `400`
3. For incorrectly formatted versions we must respond with `400` and an
appropriate error message
4. Server must add the `Elastic-Api-Version` header to responses that
hit a versioned API
5. On serverless, a request WITHOUT a version header must default to
LATEST (TODO in follow up)
a. For Kibana, on prem must default to OLDEST
## Future work
Some way to toggle the handler resolution strategy from `oldest` to
`newest`. This could be Kibana config.
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Resolves https://github.com/elastic/kibana/issues/152272
## Summary
- This PR adds maintenance windows to the alerting plugin and also adds
the create form.
- The Maintenance Windows feature is hidden by a feature flag by
default.
- The create form calls the create api, but it's expected to fail
because the api hasn't been merged.
<img width="1709" alt="Screen Shot 2023-04-03 at 2 56 45 PM"
src="https://user-images.githubusercontent.com/109488926/229601948-13a46847-bebc-4674-9446-55163a6a6589.png">
<img width="1706" alt="Screen Shot 2023-04-03 at 2 56 56 PM"
src="https://user-images.githubusercontent.com/109488926/229601997-03b232cf-0d50-4047-a92b-79ef0c1e9568.png">
<img width="1706" alt="Screen Shot 2023-04-03 at 2 57 12 PM"
src="https://user-images.githubusercontent.com/109488926/229602015-7e0110e6-dd3d-41c4-8601-64943fe01323.png">
### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
### To verify
- Enable maintenance windows by adding `ENABLE_MAINTENANCE_WINDOWS =
true` to `x-pack/plugins/alerting/common/index.ts`
- Go to
http://localhost:5601/app/management/insightsAndAlerting/maintenanceWindows
or select the Maintenance Windows link on the side nav
- Click the `Create a maintenance window` button and verify it takes you
to the create from
- Verify the bread crumbs and the return link work correctly
- Once on the create form, try to submit without entering any values and
verify that the form doesn't submit and errors are shown on the `name`
and `duration` fields
- Submit a maintenance window that is not recurring. You'll see an error
popup but verify that the request body is correct and matches what
you've selected in the form.
- Create a maintenance window that is recurring and try choosing the
different options on the recurring form. Verify that the summary at the
bottom of the form accurately reflects what you have selected.
- Submit a maintenance window that is recurring. Again, you'll see an
error popup but verify that the request body is correct and matches what
you've selected in the form.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
Resolves: https://github.com/elastic/kibana/issues/152270
Specs:
https://docs.google.com/document/u/1/d/1-QblF6P19W9o5-10Us3bfgN80GRfjSIhybHrvJS_ObA/edit
This PR implements the following:
- New maintenance window SO
- New maintenance window client in the alerting plugin (generates and
queries maintenance window events, and other CRUD functionality around
the SO)
- New maintenance window REST APIs
- Kibana privileges for reading/writing maintenance window
This PR does not include integration with task runner, a new PR will be
created to do that work.
## APIs:
```
Find all maintenance windows in current space
GET `${INTERNAL_BASE_ALERTING_API_PATH}/rules/maintenance_window/_find`
body: {}
```
```
Create maintenance window:
POST `${INTERNAL_BASE_ALERTING_API_PATH}/rules/maintenance_window`
body: {
title: string,
duration: number,
r_rule: RRule
}
```
```
Update maintenance window by ID:
POST `${INTERNAL_BASE_ALERTING_API_PATH}/rules/maintenance_window/{id}`,
body: {
title?: string,
duration?: number,
enabled?: boolean,
r_rule?: RRule,
}
```
```
Get maintenance window by ID:
GET `${INTERNAL_BASE_ALERTING_API_PATH}/rules/maintenance_window/{id}`,
```
```
Delete maintenance window by ID:
DELETE `${INTERNAL_BASE_ALERTING_API_PATH}/rules/maintenance_window/{id}`,
```
```
Archive maintenance window by ID:
POST `${INTERNAL_BASE_ALERTING_API_PATH}/rules/maintenance_window/{id}/_archive`,
body: {
archive: boolean
}
```
```
Finish maintenance window by ID:
POST `${INTERNAL_BASE_ALERTING_API_PATH}/rules/maintenance_window/{id}/_finish`,
```
## Maintenance window response schema:
```
{
id: string;
title: string;
enabled: boolean;
duration: number;
expirationDate: string;
events: DateRange[];
rRule: RRuleParams;
status: 'running' | 'upcoming' | 'finished' | 'archived';
startDate: string | null;
endDate: string | null;
createdBy: string | null;
updatedBy: string | null;
createdAt: string;
updatedAt: string;
}
```
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
Fix flaky functional test where clicking a Url formatted link opens a
new tab, but the tab isn't available before verifying the url of the new
tab.
## Summary
Closes https://github.com/elastic/kibana/issues/152431
Adds a notice when no default connectors is configured in two places.
1. On the overview page
2. On the monitor edit page (when alerting is enabled for that monitor)
<img width="1408" alt="Screen Shot 2023-04-06 at 3 38 00 PM"
src="https://user-images.githubusercontent.com/11356435/231041883-a250ccd2-58d6-4882-a425-4b8c09cc194f.png">
<img width="1270" alt="Screen Shot 2023-04-06 at 3 37 49 PM"
src="https://user-images.githubusercontent.com/11356435/231041884-3fa70b3c-8aad-4b94-9700-d0d58885ad08.png">
### Testing
1. Ensure you have no default connectors set
2. Create a monitor
3. Navigate to the overview page. Observe the notice
4. Navigate to the edit monitor page for that montior. Observe the
notice.
5. Create a second monitor. This time, disable alerting for that monitor
6. Navigate to the edit page for the second monitor. Ensure that the
notice does not appear.
---------
Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
## Summary
Resolves https://github.com/elastic/kibana/issues/154380
Adds a migration for including alert configurations for documents <
8.6.0 where the alert config was not included.
### Testing
1. Check out 8.5.0
2. Create a new oblt-cli cluster, or run `yarn es snapshot` to connect
to ES
3. Log into Kibana on 8.5.0. Create a monitor
4. Check out this branch.
5. Start Kibana and log into Kibana. Click on the monitor edit page for
the monitor you created. Inspect the network request for the monitor to
confirm `alert.status.enable: true` has been added to the monitor
attributes
- Updates the logic of `ensureDeepObject` to remove unnecessary
properties when expanding the object
- We had three versions of this helper, centralized it within `@kbn/std`
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
- Adds an action to the analysis results filter to copy a KUERY filter
for each row to the clipboard.
- Consolidates duplicate code for the Discover action into a custom
hook.
## Summary
This PR filters out all alerts that are already attached to the selected
case. To avoid breaking changes and not confuse the users (trying to
find which alert is attached to which case) the UI will not produce any
error.
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
### For maintainers
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
## Summary
Threat Detection engineers require this field going forward. We have
updated the filterlists and artifacts, we just need this query to stop
excluding the field. The field was originally excluded because
researchers didn't require it and we were mindful of customer resources.
As this is a simple query change it's not a big PR.
### Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
### Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.
When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
- Adds Cypress tests to validate that recent Policy response errors are
bubbled up and shown in Fleet Agent Details.
- Updated Fleet Agent Details display of Integrations with
`data-test-subj`'s for testing
In support of the above, the following was also introduced:
- New standalone `EndpointPolicyResponseGenerator` which also includes
one specific method to retrieve a "connect kernel failure"
- New data loaders for Endpoint Policy Responses
- Endpoint Emulator CLI was enhanced with a new panel that allows
sending policy responses to specific endpoints
- Added `EndpointMetadataGenerator.custom()` static method
- Creates a custom `EndpointMetadataGenerator` subclass based on input
arguments. allows for easier customization of generated endpoint hosts
- currently supports setting Host OS and Agent version
- Like the above, added `EndpointDocGenerator.custom()` which currently
allow for setting a custom endpoint generator for use internally
- Added `version` and `os` to `indexEndpointHosts` cypress task
- new cypress tasks:
- `indexEndpointPolicyResponse` - load a policy response
- `deleteIndexedEndpointPolicyResponse` - delete previously loaded
policy response
-
|
|
|
