Alejandro Fernández Haro
7de4733f72
[FullStory] Update snippet ( #153570 )
...
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-18 04:06:05 -07:00
Marco Liberati
0ce4f2de8a
[Lens] Reenable reporting functional tests ( #155118 )
...
## Summary
Fixes #155047 , #154958 , #154957 , #154956 , #154955 , #154954
Flaky runner with 50 runs:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2146
### Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
### Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.
When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx ) |
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-04-18 12:44:51 +02:00
Shahzad
8f4fc45a18
[Exp View] Fix e2e test ( #155123 )
2023-04-18 12:13:26 +02:00
Marco Antonio Ghiani
e472ed5fba
[Logs UI]: Fix log error on fetching previous entries ( #154459 )
...
## 📓 Summary
Closes #151700
As shown in the video on [this
comment](https://github.com/elastic/kibana/issues/151700#issuecomment-1497246729 ),
the issue was reproduced when jumping to the lowest possible edge of the
available logs in the lateral timeline.
In case there are no existing logs before the selected time cursor, the
`topCursor` value required for the previous logs call is set to `null`
and the error was triggered.
I believe in this case the conditional to trigger the error should not
only rely on the missing `topCursor` variable existence, but we should
also check whether previous logs exist with the `hasMoreBefore` state
value.
These are the conditionals in order of execution:
- Top cursor missing but has more previous entries ➡️ trigger the Error
- No more previous entries and the request is not forced ➡️ Short
circuit data fetching
- Top cursor exists => Trigger the request for previous entries.
These changes also spotted an existing bug where the `hasMoreBefore` was
never set to the API response value, but was always `true`, preventing
also showing the "Expand time range" call to action on the scenario
described above.
## 🧪 Testing
- Navigate to Logs stream
- Jump to a point in time that has no logs previously ingested
- Verify the error is not logged when scrolling and that the "extend
range" button is shown
https://user-images.githubusercontent.com/34506779/230292210-c2690c37-efa1-4b05-a237-f14eb78d26eb.mov
---------
Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com>
2023-04-18 12:03:24 +02:00
Marco Liberati
779e553f81
[Lens] Improve Ignore global filters UI ( #154441 )
...
## Summary
Fixes #154316
This PR revisits partially the Layer Settings UI in order to support the
`Data` and `Appereance` split in the UI and enhance the `ignore global
filters` UI to make it clearer for the user the state of this setting.
<img width="353" alt="Screenshot 2023-04-05 at 11 57 55"
src="https://user-images.githubusercontent.com/924948/230057975-37f92e6f-c70c-4509-a351-6eb932889d0c.png ">
when the setting is disabled (to use global filters) then nothing is
shown:
<img width="336" alt="Screenshot 2023-04-05 at 11 59 18"
src="https://user-images.githubusercontent.com/924948/230058311-6f8f6dab-7a2f-42f1-b899-de371ed9f0b0.png ">
On Annotations layer that is the only available setting:
<img width="374" alt="Screenshot 2023-04-05 at 11 58 03"
src="https://user-images.githubusercontent.com/924948/230058004-016e99b0-0786-46fa-aaed-a0c42ebc18b6.png ">
The new refactoring can now handle multiple settings for each panel
section as shown in the Partition charts settings panel:
<img width="375" alt="Screenshot 2023-04-05 at 12 20 35"
src="https://user-images.githubusercontent.com/924948/230058207-fe2c7d64-e25b-43a3-a612-b63aa46e35c6.png ">
### Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
### Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.
When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx ) |
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
---------
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
2023-04-18 11:31:37 +02:00
Marco Liberati
9d096c5623
[Lens] Improve reporting size for Lens visualizations ( #154931 )
...
## Summary
Fix #154894
This PR "rotate" most of Lens visualizations to have a landscape version
of the PNG/PDF exports.
### Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
### Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.
When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx ) |
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-04-18 11:31:21 +02:00
Coen Warmer
c75863385d
Use Observability Page Template from Observability Shared in APM and Profiling ( #154776 )
...
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-18 11:03:44 +02:00
Sean Story
617debdf79
Generate the sample doc differently for sourceField vs fieldMappings ( #154980 )
...
## Summary
Generates the sample document for testing your pipeline differently
depending on if you are working with `sourceField` and
`destinationField` vs if you're using a `FieldMapping[]`.
Before:
<img width="339" alt="Screenshot 2023-04-14 at 2 05 58 PM"
src="https://user-images.githubusercontent.com/5288246/232134387-d57f5368-c01d-4556-92af-9bfbe570db76.png ">
After:
<img width="442" alt="Screenshot 2023-04-14 at 2 06 06 PM"
src="https://user-images.githubusercontent.com/5288246/232134403-0c759823-1fa0-4968-95fa-267f86157e42.png ">
### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-04-18 10:42:26 +02:00
Alejandro Fernández Haro
823cc3f49b
[getSavedObjectsCount] Use soClient instead of .kibana searches ( #155035 )
...
## Summary
As part of #154888 , we need to stop making direct requests to the index
`.kibana`, and use the SO Clients instead.
This PR changes the utility `getSavedObjectsCount` to use aggregations
in the SO client.
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
### For maintainers
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
I'm pointing to `main` because it's an improvement we needed anyway.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-18 10:15:35 +02:00
Julia Rechkunova
682f12ea77
[Discover][Saved Query] Add schema for Saved Query SO ( #154230 )
...
## Summary
A follow up for https://github.com/elastic/kibana/pull/153131
This PR adds schema for Saved Query SO type.
2023-04-18 09:11:07 +02:00
Cristina Amico
970de9147e
[Fleet] Surface new overview dashboards in fleet ( #154914 )
...
Closes https://github.com/elastic/kibana/issues/153848
## Summary
- Adds two link buttons on top of agent list page to access "Ingest
overview" and "Agent Info" dashboards
<img width="1444" alt="Screenshot 2023-04-13 at 15 22 53"
src="https://user-images.githubusercontent.com/16084106/231772174-00c00a8e-62f1-43ea-a935-bc12f56f3e50.png ">
The links are built using the new URL service
[locator](e80abe8108/x-pack/plugins/fleet/public/hooks/use_locator.ts (L14)https://github.com/elastic/kibana/blob/main/src/plugins/share/README.mdx#using-locator-of-another-app )
method;
- Refactoring existing instances of `useKibanaLink` to use the url
locator instead;
These new dashboards were already accessible from the ` elastic_agent.*`
datastreams table actions, however I replaced the `useKibanaLink` hook
there as well:
<img width="1412" alt="Screenshot 2023-04-13 at 16 03 47"
src="https://user-images.githubusercontent.com/16084106/231784273-693c7f36-4545-4c06-a05e-4f09e53bd903.png ">
TODO: I don't know where to add the "Integrations" dashboard yet, I'm
not sure it should go on the Integrations details page.
### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
---------
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-04-18 08:44:16 +02:00
Kibana Machine
f892faceb4
[api-docs] 2023-04-18 Daily api_docs build ( #155109 )
...
Generated by
https://buildkite.com/elastic/kibana-api-docs-daily/builds/311
2023-04-18 00:58:20 -04:00
Karl Godard
0a5b4233d1
Session view and k8s dashboard fixes ( #154982 )
...
## Summary
- fixes some issues in session_view wrt to logs-cloud_defend.process*
data.
- added a 'collapse all' children feature. with sticky scroll session
leader!
- k8s dashboard session table: user.name -> user.id (id is more likely
to be set for both endpoint and cloud-defend)
- Fixed a major bug when 'searching within terminal'. If a process is
highlighted it would cause kibana to blow up.
- session view handling of session leader user info improved.
- codeowners updated. awp-viz -> sec-cloudnative-integrations
- a badge will be added to the selector header when it's not in used by
a response flow
### Screenshots
Sticky session leader demo:
https://www.loom.com/share/b039e48fdfd647b291f293d643339660
### Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-17 16:22:28 -07:00
Rickyanto Ang
28b1f96d47
[Cloud Posture] Fix for Flaky test Column Sort ( #154877 )
...
## Summary
This PR for fixing the 'Flakiness' for our FTR Column Sort test cases.
The fix includes adding a 1 second delay or sleep between the test
clicking on the column its trying to sort and the test getting values
for that column.
There seems to be a problem from time to time where the values on that
column is not correct for a split second after clicking on the column to
sort it. Adding 1 second delay allows enough time for the column to sort
and show the correct value before we get the value for comparison with
the sorted (using our sorting function on the test)
This delay also fix the issue where the test fails because it checks for
an element while the page is still loading. I ran this 'fix' on our
flaky test runner for over 1000 runs and it hasn't fail so far, whereas
back then It would fail 3-4 times out of 450 runs
### Some other stuff that I tried before choosing this fix includes:
- Breaking the Column sort test cases into smaller test, currently we
test all Column sort in 1 test thus when 1 fail it might fail the next
one too.
- wait until loading element doesn't exist but I seem to be encountering
some issue when i use waitFor. Thus, I switch it to check if loading
element don't exist but It doesnt seem to help that much on fixing
column sort issue
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-17 15:18:27 -07:00
Nicolas Chaulet
ce912a9231
[Fleet] Fix request diagnostics tests ( #155092 )
2023-04-17 18:06:35 -04:00
Yara Tercero
9a095602f8
[Security Solution][Exceptions] - Fix exception operator logic when mapping conflict ( #155071 )
...
## Summary
Addresses https://github.com/elastic/kibana/issues/154962 .
2023-04-17 17:05:55 -04:00
Devon Thomson
b689c27ce2
[Portable Dashboards] Export Dashboard Listing Table ( #154295 )
...
export the Dashboard Listing Page component lazily. This component is a wrapper around the TableListView and can be used as-is.
2023-04-17 16:22:06 -04:00
Navarone Feekery
8d9777b94f
[Enterprise Search] Add required flag to connector configurable fields ( #155043 )
...
## Summary
Adds a required flag to configurable fields. If the configuration field
has `required: true` then the input will be required as well.
This is not applicable to radios and switches, which can't be null.
2023-04-17 21:57:15 +02:00
Patrick Mueller
efc7ca6a07
add xpack.actions.enableFooterInEmail to the docker config list ( #155076 )
...
## Summary
In PR https://github.com/elastic/kibana/pull/154919 , we forgot to
add the config to the docker allow-list in the appropriate file.
We add it in this PR.
2023-04-17 15:51:55 -04:00
Melissa Alvarez
ec0a87c5cc
[ML] Explain Log Rate Spikes: add popover to analysis table for viewing other field values ( #154689 )
...
## Summary
Related meta issue: https://github.com/elastic/kibana/issues/146065
Adds unified field list popover to show top values for fields in the
Explain Log Rate Spikes analysis table.
<img width="1350" alt="image"
src="https://user-images.githubusercontent.com/6446462/231584775-cade3e53-560f-4622-811a-c56747c2e469.png ">
Field pairs table:
<img width="1175" alt="image"
src="https://user-images.githubusercontent.com/6446462/231584835-1b82a0bb-eff0-477b-a060-c8b74a067500.png ">
<img width="976" alt="image"
src="https://user-images.githubusercontent.com/6446462/231578276-9d99ed13-852b-4744-a9c3-5dd11a35c46d.png ">
Expanded row in grouped table:
<img width="1166" alt="image"
src="https://user-images.githubusercontent.com/6446462/231584916-51271006-94fa-4a25-ac14-e7a99f9728f9.png ">
### Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-17 13:50:04 -06:00
Ying Mao
5a818176ef
[Response Ops] [Alerting] Excluding ECS fields of type constant_keyword from ECS field map ( #155075 )
...
Fields mapped as `constant_keyword` can cause issues when used in the
alerts as data mapping where multiple types of sources are combined into
one index. These fields were previously excluded from the ECS field
mapping used by alerts as data. We included them because we wanted to
use ECS as closely as possible but it is causing downstream issues so
we'll continue excluding them until we decide we need them at some point
in the future.
## To verify:
1. Start ES & Kibana
2. Inspect the `.alerts-ecs-mappings` component template mapping and
verify there are no fields with type `constant_keyword`
2023-04-17 15:31:18 -04:00
Luke
153994d810
[Security Solution] Move datatable to package ( #150899 )
...
## Summary
[Related issue](https://github.com/elastic/kibana/issues/150603 )
This PR extracts the DataTableComponent, related redux infrastructure
and some helpers into standalone package.
### Checklist
Delete any items that are not applicable to this PR.
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
2023-04-17 21:02:28 +02:00
Kibana Machine
22956209ac
skip failing test suite ( #154578 )
2023-04-17 13:59:15 -04:00
Kibana Machine
55d5f11d13
skip failing test suite ( #154726 )
2023-04-17 13:58:58 -04:00
Kibana Machine
3925e93dbc
skip failing test suite ( #154640 )
2023-04-17 13:13:57 -04:00
Paulo Henrique
3214872013
[Cloud Posture] add EmptyState component ( #154619 )
...
### Summary
This PR is part of a [Quick wins
ticket](https://github.com/elastic/security-team/issues/6291 ). It
improves the message displayed when performing a search or filter that
doesn't return values. It also provides a button to reset the filters
and a link to the docs.
This PR introduces a generic `EmptyState` component so that it can be
reusable across all the Cloud Security plugin tables.
### Screenshot
Findings page
Findings page by resource
Findings resource page
2023-04-17 14:05:43 -03:00
Zacqary Adam Xeper
0bd81d8da1
[SharedUX] Export timezone list from Core UI ( #154742 )
...
## Summary
Exports the list of valid Kibana timezones from the Core UI package, so
that it can be used in the snooze scheduler UI.
Previously we were using the same moment.tz list, but didn't have the
compatibility filter from Core UI. This will ensure the list of valid
timezones is synced up everywhere we need to show them.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-17 10:01:23 -07:00
Kibana Machine
8360064a39
skip failing test suite ( #154958 )
2023-04-17 12:54:35 -04:00
Jaime Soriano Pastor
65a116fed7
[Fleet] Add support for fields of type aggregate_metric_double ( #154920 )
...
## Summary
Add support for fields of type `aggregate_metric_double` in EPM.
Change in package spec introduced in
https://github.com/elastic/package-spec/pull/500 .
Fixes https://github.com/elastic/kibana/issues/154867
Closes https://github.com/elastic/package-spec/issues/457
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios.
### How to test
* Modify a package to include a field with type
`aggregate_metric_double`, for example like this:
```
- name: some_metric
type: aggregate_metric_double
metrics: [ "min", "max", "sum", "value_count" ]
default_metric: "max"
```
* Install elastic package with this branch of the package-spec included:
https://github.com/elastic/package-spec/pull/500 , for this, from an
elastic-package working directory:
* `go mod edit -replace
github.com/elastic/package-spec/v2=github.com/elastic/package-spec@main`
* `go mod tidy`
* `make install`
* Build the package with `elastic-package build -v`.
* Install the package with `elastic-package install -v`.
* Check that the template contains the expected field.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-17 18:28:18 +02:00
Sean Story
ddd2e7e317
Fix double-prefixing of 'ml.inference' ( #154979 )
...
## Summary
We were double-prefixing the target field:
<img width="871" alt="screenshot"
src="https://user-images.githubusercontent.com/5288246/232129339-890af78c-aef2-4433-b3e7-f9a530f8c121.png ">
This strips any existing prefix before appending one. It also adds a
test.
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2023-04-17 09:23:05 -07:00
Faisal Kanout
01c0d0152c
[AO] - Add logs threshold ratio chart to the alert details page ( #155024 )
...
## Summary
It fixes #155022 by adding the new ratio chart
<img width="1197" alt="Screenshot 2023-04-17 at 16 17 45"
src="https://user-images.githubusercontent.com/6838659/232513836-3ac2e18b-a1d6-404b-aaa7-9670d3ea0fff.png ">
### Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
---------
2023-04-17 09:21:39 -07:00
Kibana Machine
6259bb9098
skip failing test suite ( #154913 )
2023-04-17 12:03:49 -04:00
Sébastien Loix
406fe97016
[Table list view] Fix sort by label ( #154922 )
2023-04-17 08:51:16 -07:00
Nicolas Chaulet
50cedc25e0
[Fleet] Update instructions for Fleet server port ( #154674 )
2023-04-17 11:48:34 -04:00
Kibana Machine
644e0a81d4
skip failing test suite ( #154452 )
2023-04-17 11:44:58 -04:00
Kibana Machine
404ec58660
skip failing test suite ( #137032 )
2023-04-17 11:44:31 -04:00
Abdul Wahab Zahid
1b7830775e
Make "Text Assertion" form field optional for Single Page monitors ( #154795 ) ( #153929 )
...
Makes the "Text Assertion" field optional in Monitor Add/Edit form.
2023-04-17 17:42:22 +02:00
Terrance DeJesus
41cd8cb96a
[Security Solution] Filterlist Update for Endpoint Process API Events ( #154746 )
...
## Related
* https://github.com/elastic/security-team/issues/4613
## Summary
Updates endpoint alerts telemetry filter list to add fields for API
events.
2023-04-17 11:41:19 -04:00
Patrick Mueller
bcfe4b0005
[ResponseOps] provide config to turn off email action footer ( #154919 )
...
resolves https://github.com/elastic/kibana/issues/135402
Allows deployments to not have the default footer added to alerting
emails via the new `xpack.actions.enableFooterInEmail` config setting.
The default value is `true`, which renders the footer. Setting the
value to `false` will cause no footer to be rendered.
Also changes the footer separator from `--` to `---`, which renders
nicer in HTML, as a `<hr>` element.
2023-04-17 11:19:16 -04:00
Elastic Machine
70d5dad847
[main] Sync bundled packages with Package Storage ( #155040 )
...
Automated by
https://internal-ci.elastic.co/job/package_storage/job/sync-bundled-packages-job/job/main/3162/
Co-authored-by: apmmachine <infra-root+apmmachine@elastic.co>
2023-04-17 08:09:59 -07:00
Anton Dosov
bd664eb690
add BlueOak-1.0.0 to the list of allowed licences ( #155018 )
...
## Summary
Adding `BlueOak-1.0.0` to the list of allowed licenses as it was
green-listed.
We need this license in Kibana [to update
Puppeteer](https://github.com/elastic/kibana/issues/151211#issuecomment-1489959322 )
as one of its nested dependencies now uses this license.
2023-04-17 17:02:10 +02:00
Chenhui Wang
47c71b3025
Use unsigned_long for field indexed_document_volume ( #155014 )
...
## Summary
### Part of https://github.com/elastic/connectors-python/issues/735
The field `indexed_document_volume` (in bytes) in
`.elastic-connectors-sync-jobs` is of type `integer`, which can hold a
maximum value of `2^31-1`, which is equivalent to 2-ish GB. This PR
changes it to `unsigned_long`, which can hold a maximum value of
`2^64-1`, which is equivalent to 18-ish Exa Bytes (1 Exa Byte = 1000
PB).
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-04-17 22:59:48 +08:00
gchaps
049b7c8866
Updates docs landing page ( #154400 )
...
## Summary
This PR updates the Kibana docs landing page to move the most visited
docs higher on the page.
[Preview](https://kibana_154400.docs-preview.app.elstc.co/guide/en/kibana/master/index.html )
---------
Co-authored-by: lcawl <lcawley@elastic.co>
2023-04-17 07:59:31 -07:00
Kibana Machine
07a341277e
skip failing test suite ( #151636 )
2023-04-17 10:55:17 -04:00
Rodney Norris
d60107467d
Enterprise Search(nav): refactor nav with applications ( #154783 )
...
## Summary
### Screenshots
Selected Search App
Selected Analytics Collection
2023-04-17 09:48:22 -05:00
Anton Dosov
4edb583c18
[Content Management] Remove dep from content_management -> saved_object_finder ( #155013 )
...
## Summary
Follow up https://github.com/elastic/kibana/pull/154819 ,
@mattkime pointed out a problem that cm can't depend on
saved_object_finder
https://github.com/elastic/kibana/pull/154819/files#diff-635bc20df585b656afebba3ebf338ff997e735df933f704cc5f253a74b3503ddR17
2023-04-17 16:25:58 +02:00
Lola
eb6bfd8476
[Cloud Posture] Vul mgmt flyout details panel ( #154873 )
...
## Summary
Summarize your PR. If it involves visual changes include a screenshot or
gif.
<img width="1695" alt="Screen Shot 2023-04-12 at 5 04 30 PM"
src="https://user-images.githubusercontent.com/17135495/231596052-d47d0e7a-7abb-4aa1-a022-0fd1b1def981.png ">
<img width="1656" alt="Screen Shot 2023-04-12 at 5 30 55 PM"
src="https://user-images.githubusercontent.com/17135495/231596060-89ea7d40-8727-4dab-a3ba-c57cf83ad0cc.png ">
<img width="1659" alt="Screen Shot 2023-04-12 at 5 31 09 PM"
src="https://user-images.githubusercontent.com/17135495/231596067-839c0c1f-84a6-42b5-9683-77c70594af65.png ">
Flyou details Feature includes:
Results are fetched from the
logs-cloud_security_posture.vulnerabilities-default index.
A Flyout opens when clicking the Expand Icon in the Vulnerabilities
table.
The Flyout has two tabs: Overview and JSON.
The Overview tab consists of four sections: CVSS, Data source, Publish
date, Description, Fixes, and Vulnerability Scores
TODO
Add pagination in follow up pr
Add unit tests
2023-04-17 11:17:47 -03:00
Sean Story
d213107c15
Have createPipeline pass along fieldMappings ( #154951 )
...
## Summary
previously createPipeline wasn't passing along fieldMappings, which was
leading to errors like:
<img width="968" alt="screenshot"
src="https://user-images.githubusercontent.com/5288246/231869339-82756b7a-a899-4e91-b056-b20512358c21.png ">
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process )
2023-04-17 08:43:46 -05:00
Klim Markelov
f3e5759a73
[Behavioral Analytics] Change events state check ( #154744 )
...
## https://github.com/elastic/enterprise-search-team/issues/4270
### Description
In order to improve user experience, it's required to introduce a
Callout when a datastream doesn't have any events.
This PR is dedicated to:
1. Introducing the `EuiCallout` element that redirects to the
Integration page, when clicking on "Learn how" button
2. Changing the way how we check if datastream has any events
### Screenshots
<img width="1341" alt="Screenshot 2023-04-11 at 18 19 23"
src="https://user-images.githubusercontent.com/5709507/231226098-947cc214-e738-496e-84bc-d18168967c9f.png ">
2023-04-17 15:28:13 +02:00
Coen Warmer
035d28e757
Remove Has Data check from Alerts page so page is always accessible ( #154851 )
...
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2023-04-17 15:15:15 +02:00
