62326 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Angela Chuang	e80abe8108	[SecuritySolution] Display visualization count (#154457) ... ## Summary Bug description: Showing ___ events subtitles were missing from alerts and events histograms. After: <img width="832" alt="Screenshot 2023-04-05 at 15 28 23" src="https://user-images.githubusercontent.com/6295984/230113674-ee34be46-7a45-4e12-8376-f20fe33b0133.png"> <img width="1669" alt="Screenshot 2023-04-05 at 15 28 42" src="https://user-images.githubusercontent.com/6295984/230113684-660567bb-c594-4542-9abb-66bcf5c29ffa.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios	2023-04-13 05:59:01 -07:00
Faisal Kanout	89e8d03e6b	[AO] - Add rule-specific fields, threshold, and reuse alert details package components (#154569) ... ## Summary It fixes #153675, fixes #153567, fixes #153946, fixes #154845 <img width="1603" alt="Screenshot 2023-04-11 at 17 40 38" src="https://user-images.githubusercontent.com/6838659/231215968-63b9ab6d-3b82-47c6-ace9-347306283b2a.png"> ---------	2023-04-13 05:40:03 -07:00
Jonathan Buttner	fe9985b566	[Cases] Adding mime type telemetry (#154679) ... This PR adds telemetry for collecting statistics for the mimetypes of the files uploaded to cases. It only looks for the top 20 mime types using a terms aggregation. It does this across all cases and broken down by owner. On the telemetry server we'll need to create a single document per entry in the array here so we can do filtering for the visualizations. Example ``` "topMimeTypes": [ { "count": 2, "name": "image/png" }, { "count": 1, "name": "application/json" }, { "count": 1, "name": "text/plain" } ] ``` <details><summary>Example telemetry result</summary> "cases": { "cases": { "all": { "total": 1, "daily": 1, "weekly": 1, "monthly": 1, "status": { "open": 1, "inProgress": 0, "closed": 0 }, "syncAlertsOn": 1, "syncAlertsOff": 0, "totalUsers": 1, "totalParticipants": 1, "totalTags": 1, "totalWithAlerts": 0, "totalWithConnectors": 0, "latestDates": { "createdAt": "2023-04-11T16:07:00.565Z", "updatedAt": "2023-04-11T16:07:17.712Z", "closedAt": "" }, "assignees": { "total": 0, "totalWithZero": 1, "totalWithAtLeastOne": 0 }, "attachmentFramework": { "externalAttachments": [ { "type": ".files", "average": 4, "maxOnACase": 4, "total": 4 } ], "persistableAttachments": [], "files": { "averageSize": 3, "average": 4, "maxOnACase": 4, "total": 4, "topMimeTypes": [ { "count": 2, "name": "image/png" }, { "count": 1, "name": "application/json" }, { "count": 1, "name": "text/plain" } ] } } }, "sec": { "total": 0, "daily": 0, "weekly": 0, "monthly": 0, "attachmentFramework": { "externalAttachments": [], "persistableAttachments": [], "files": { "averageSize": 0, "average": 0, "maxOnACase": 0, "total": 0, "topMimeTypes": [] } }, "assignees": { "total": 0, "totalWithZero": 0, "totalWithAtLeastOne": 0 } }, "obs": { "total": 0, "daily": 0, "weekly": 0, "monthly": 0, "attachmentFramework": { "externalAttachments": [], "persistableAttachments": [], "files": { "averageSize": 0, "average": 0, "maxOnACase": 0, "total": 0, "topMimeTypes": [] } }, "assignees": { "total": 0, "totalWithZero": 0, "totalWithAtLeastOne": 0 } }, "main": { "total": 1, "daily": 1, "weekly": 1, "monthly": 1, "attachmentFramework": { "externalAttachments": [ { "type": ".files", "average": 4, "maxOnACase": 4, "total": 4 } ], "persistableAttachments": [], "files": { "averageSize": 3, "average": 4, "maxOnACase": 4, "total": 4, "topMimeTypes": [ { "count": 2, "name": "image/png" }, { "count": 1, "name": "application/json" }, { "count": 1, "name": "text/plain" } ] } }, "assignees": { "total": 0, "totalWithZero": 1, "totalWithAtLeastOne": 0 } } }, "userActions": { "all": { "total": 5, "daily": 5, "weekly": 5, "monthly": 5, "maxOnACase": 5 } }, "comments": { "all": { "total": 0, "daily": 0, "weekly": 0, "monthly": 0, "maxOnACase": 0 } }, "alerts": { "all": { "total": 0, "daily": 0, "weekly": 0, "monthly": 0, "maxOnACase": 0 } }, "connectors": { "all": { "all": { "totalAttached": 0 }, "itsm": { "totalAttached": 0 }, "sir": { "totalAttached": 0 }, "jira": { "totalAttached": 0 }, "resilient": { "totalAttached": 0 }, "swimlane": { "totalAttached": 0 }, "maxAttachedToACase": 0 } }, "pushes": { "all": { "total": 0, "maxOnACase": 0 } }, "configuration": { "all": { "closure": { "manually": 0, "automatic": 0 } } } } </details> ## Testing To test modify this file: https://github.com/elastic/kibana/blob/main/x-pack/plugins/cases/server/telemetry/schedule_telemetry_task.ts With: ``` export const scheduleCasesTelemetryTask = ( taskManager: TaskManagerStartContract, logger: Logger ) => { (async () => { await taskManager .ensureScheduled({ id: CASES_TELEMETRY_TASK_NAME, taskType: CASES_TELEMETRY_TASK_NAME, schedule: { interval: `${MINUTES_ON_HALF_DAY}m`, }, scope: ['cases'], params: {}, state: {}, }) .catch((err) => { logger.debug( `Error scheduling cases task with ID ${CASES_TELEMETRY_TASK_NAME} and type ${CASES_TELEMETRY_TASK_NAME}. Received ${err.message}` ); }); await taskManager.runSoon(CASES_TELEMETRY_TASK_NAME); })(); }; ``` This will cause the telemetry to be sent as soon as the server is restarted. To generate files and attachments to add stats to the telemetry I created this python script: https://github.com/elastic/cases-files-generator To retrieve the telemetry: ``` POST http://localhost:5601/api/telemetry/v2/clusters/_stats { "refreshCache": true, "unencrypted": true } ```	2023-04-13 08:23:02 -04:00
Stratoula Kalafateli	07a7e765f6	[TSVB][AggBased] Transfer panel title and description to the converted Lens panels (#154713) ... ## Summary Closes https://github.com/elastic/kibana/issues/153913 There are 2 ways to convert a legacy visualizations to Lens 1. Go to the legacy editor and click the Visualize in Lens top nav button 2. Open the panel menu on the dashboard level and click Convert to Lens On the first case the panel title and description was not passed to the converted panel On the second case the panel title was passed but not the description This PR fixes all the aforementioned scenarios  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>	2023-04-13 15:21:00 +03:00
Anton Dosov	10f2015d17	[Content Management] Cross Type Search - paginate and tags filter (#154819) ... ## Summary Follow up to https://github.com/elastic/kibana/pull/154464 Partially resolve https://github.com/elastic/kibana/issues/152224 - implement pagination and tags filtering	2023-04-13 03:40:17 -07:00
Stratoula Kalafateli	3840136d75	[Unified search] Unloads selected query if is deleted (#154644) ... ## Summary Closes https://github.com/elastic/kibana/issues/151554 Unloads the selected saved query if it is deleted in order to be able to be re-applied.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>	2023-04-13 13:33:14 +03:00
Stratoula Kalafateli	4dfebedd2f	Fix accessibility issues in suggestion panel (#154889) ... ## Summary Closes https://github.com/elastic/kibana/issues/154787 Fixes the a11y problem mentioned in the issue <img width="1251" alt="image" src="https://user-images.githubusercontent.com/17003240/231686912-f3aa6f1e-f8bd-4c3d-bc94-9e165490c028.png">	2023-04-13 13:33:01 +03:00
Michael Dokolin	768fe1af31	[Migrations] Add migrationVersion property to the Saved Objects API output (#154364)	2023-04-13 12:05:58 +02:00
Sébastien Loix	42a893db40	[Content Management] Maps onboard (#153304)	2023-04-13 10:32:39 +01:00
Coen Warmer	045b58fe5b	Add Create Rule from SLO Creation form (#154812)	2023-04-13 00:56:45 -07:00
Kevin Delemme	b86358e208	feat(slo): Add more tooltip in burn rate rule (#154840) ... Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>	2023-04-13 00:55:47 -07:00
Ievgen Sorokopud	124b919127	[RAM][SECURITYSOLUTION][ALERTS] - Update action form UI to fit security solution needs (#154531) (#154526) ... ## Summary These changes customise action form UI for security solution needs.  To see how new design works in security solution, you can use this [draft PR](https://github.com/elastic/kibana/pull/153113) which consists of all the changes. I split that big PR into smaller independent pieces for easier review process. Fixes #154531 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>	2023-04-13 09:18:43 +02:00
Kibana Machine	a6e18d1d5d	[api-docs] 2023-04-13 Daily api_docs build (#154883) ... Generated by https://buildkite.com/elastic/kibana-api-docs-daily/builds/306	2023-04-13 00:56:05 -04:00
Lukas Olson	fb44bebf58	[data.search] Update routes to not accept query (#154869)	2023-04-12 21:44:02 -07:00
Jonathan Budzenski	d83f1fe5c1	skip failing suite (#154859)	2023-04-12 17:58:40 -05:00
Kevin Logan	935a16d44f	[Security Solution] Unskip tests after ES promotion fixes (#154863) ... ## Summary Resolves https://github.com/elastic/kibana/issues/154740 https://github.com/elastic/kibana/issues/154741 These tests were skipped due to an ES promotion block. This PR: https://github.com/elastic/elasticsearch/pull/95187 was added on the ES side and another snapshot was promoted which should allow us to un skip these tests. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>	2023-04-12 17:47:58 -04:00
Coen Warmer	49b763f8e7	[SLO] Add refresh button to SLO Detail page (#154856)	2023-04-12 14:31:38 -07:00
Joseph McElroy	515d27086d	[Behavorial Analytics] Link to Manage Datastream Page (#154857) ... Adds a link to navigate to the manage datastream. This allows the customer to customise the ILM policy or view datastream settings. <img width="316" alt="image" src="https://user-images.githubusercontent.com/49480/231541459-3cb2e4d0-8f1e-41a8-8100-85f32ebffff6.png"> <img width="1507" alt="image" src="https://user-images.githubusercontent.com/49480/231541545-67563edf-a40a-42e8-9bbd-cab0e07924b5.png"> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>	2023-04-12 21:41:26 +01:00
Cauê Marcondes	263af61f5d	[Fleet] Fix package license check to use new constraints.elastic.subs… (#154831) ... closes https://github.com/elastic/kibana/issues/154822 Uses the new `conditions.elastic.subscription` field to check elastic subscription. Error message when `conditions.elastic.subscription` is set to **enterprise** but ES is under **basic** license. <img width="832" alt="Screenshot 2023-04-12 at 1 31 21 PM" src="https://user-images.githubusercontent.com/55978943/231538154-fd3c54fd-228a-45f1-b159-6c46ce622c25.png">	2023-04-12 15:50:43 -04:00
Kyle Pollich	e2d790d8a1	[Fleet] Update URL + add fetch retries for agent versions build task (#154847) ... ## Summary - Update URL to point at `/api/product_versions` per @brianjolly's input - Add basic retry loop per @jbudz suggestion cc @juliaElastic --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>	2023-04-12 14:30:06 -05:00
Lola	b07743b269	[Cloud Posture] onboarding prompts for vul_mgmt (#154118) ... ## Summary This PR adds onboarding prompts for when vulnerability management integration is not installed and when vulnerability management is installed then show scanning empty prompt. A `<NoVulnerabilitesState/>` component checks for `vuln_mgmt` status. If the status is `not-deployed` or `indexing` then show <ScanningVulnerabilitiesEmptyPrompt/> The packageNoInstalledRender component will listen for the current tab and renders on `useLocation().pathname`. If `currentTab` is 'vulnerabilities' then we show `<VulnerabilitiesFindingsInstalledEmptyPrompt/>`. If `currentTab` is `configurations` then show `<ConfigurationFindingsInstalledEmptyPrompt/>` Installed Prompt <img width="1728" alt="Screen Shot 2023-03-30 at 3 45 35 PM" src="https://user-images.githubusercontent.com/17135495/229010609-51a8f009-0fe1-45f3-8452-02bdd4234367.png"> Scanning Envioronment <img width="1724" alt="Screen Shot 2023-03-30 at 3 45 20 PM" src="https://user-images.githubusercontent.com/17135495/229010649-2d8c8482-c7d2-4040-927d-310354f99a94.png"> --------- Co-authored-by: Kfir Peled <kfir.peled@elastic.co>	2023-04-12 14:55:21 -04:00
Coen Warmer	fb0c1bf400	Remove Beta badge from the SLO item in the sidebar Nav (#154854)	2023-04-12 11:45:39 -07:00
Hannah Mudge	b8f490a728	[Dashboard] [Controls] Prevent control group reload on output change (#154763) ... Closes https://github.com/elastic/kibana/issues/154146 ## Summary This PR fixes a race condition for chained options list controls where making changes to the output of the first control in the chain would sometimes cause the chained controls to be stuck in an infinite loading state. (Thanks to @ThomThomson for helping me narrow this down). Basically, before this, **any** change to the control group output (for example, by making a selection in an options list control) would cause the dashboard to `forceRefresh` the entire control group: 682e2ed6ae/src/plugins/dashboard/public/dashboard_container/embeddable/integrations/controls/dashboard_control_group_integration.ts (L174-L185) So, imagine you have a dashboard with two chained controls: control A and control B. Making a selection in control A will cause the following chain of events: 1. Make a selection in control A 2. Control B refetches its suggestions because hierarchical chaining is turned on 3. At "the same time" (more-or-less), the subscription above fires due to step 1 changing the control group output, and so the dashboard forces a refresh of the control group 4. This causes both control A and control B to refetch their suggestions unnecessarily, due to the `reload` logic of `options_list_embeddable.tsx`. 682e2ed6ae/src/plugins/controls/public/options_list/embeddable/options_list_embeddable.tsx (L417-L421) Because control B has now had two of the "same" requests sent to the server, this caused a race condition where, depending on how fast things completed and the state of the caching (which is cleared on `reload` but is **not** cleared when a new selection is made), sometimes **both** requests would get aborted and so the following early return would prevent control B from setting its loading state to `false` (i.e. it would get stuck in an infinite loading state): 682e2ed6ae/src/plugins/controls/public/options_list/embeddable/options_list_embeddable.tsx (L329-L337) This PR prevents this race condition by only refreshing the **dashboard's children** (i.e. the visualization embeddables) and not the control group itself when the control group's output changes - as an extra benefit, this makes the control group more efficient than it was before since the unnecessary refresh is no longer slowing things down 💃 ### Flaky Test Runner <a href="https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2114"><img src="https://user-images.githubusercontent.com/8698078/231301760-a0c16e9b-fa7e-426c-9483-077527d39faa.png"/></a> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)	2023-04-12 11:08:51 -06:00
Coen Warmer	f2a4dbfcad	Add Create Rule from SLO List item (#154800)	2023-04-12 18:31:56 +02:00
Sander Philipse	b431bccfc9	[Enterprise Search] Fix logic for hidden indices (#154833) ... Fixes a minor bug in the logic to determine whether an index is hidden.	2023-04-12 09:25:44 -07:00
Paulo Henrique	e546d5297d	[Cloud Security] [Findings] [Vulnerabilities] Vulnerabilities Table (#154388) ... ### Summary Ticket: #150510 This PR adds the Vulnerability Management table to the Findings page - Vulnerabilities tab. It also - Fetches results from the `logs-cloud_security_posture.vulnerabilities-latest`. - Uses EuiGrid component - Has sorting and pagination controls (it shares page size state with configurations findings) - All columns except the Actions column are sortable - Items per page to default to 10, with options of 10, 25, 100 - Add an Empty results message in case of no results This PR also added two new hooks: - *useCloudPostureTable*: Hook for managing common table state and methods for Cloud Posture - *useDataViewForIndexPattern*: Hook that extracts data view from the common `logs-*` and filters the fields to narrow to a specific index pattern. This allows us to have a search bar and filter working without the need to create a Data View. Todo: Add tests for the vulnerability table ### Screenshots Initial State  Filtering    Empty State (Sharing component with Configurations tab)  Sorting 	2023-04-12 09:01:43 -07:00
Christos Nasikas	bb73249d81	[Cases] Filter out alerts already attached to the case on the backend (#154629) ... ## Summary This PR filters out alerts already attached to a case on the backend. The schema of the alerts in a case is: ``` { alertId: string | string[] index: string | string[] } ``` So the `alertId` can contain multiple alert ids. In this case, if an ID is attached to the case it will be removed from the `alertId` array. If all alerts are attach to the case no attachment will be created. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)	2023-04-12 08:59:48 -07:00
Dima Arnautov	c3e6e70428	[ML] Support multiple change point requests (#154237)	2023-04-12 17:58:50 +02:00
David Sánchez	fbe024306c	[Security Solutions][Endpoint] Use id instead of identifier to get fleet artifact (#154810) ... ## Summary Get fleet artifacts by `artifact.id` instead of by `artifact.identifier` before pushing them to the endpoint manifest. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>	2023-04-12 17:54:21 +02:00
Tiago Costa	22015b470f	skip flaky suite (#119267)	2023-04-12 16:16:34 +01:00
Jill Guyonnet	7d946ffe56	[Fleet] Disable TSBD setting switch when enabled (#154048) ... ### Summary Disable `Time-series indexing (TSDB)` switch in experimental datastream settings if TSDB is enabled in the package itself. As part of this fix, the following changes are included in compliance with UX rules: * Rename toggle label from `Time-series indexing (TSDB)` to `Time-series database (TSDB) indexing`. * When the toggle is disabled, add a question mark icon with a tooltip with text `TSDB indexing is enabled by the integration`. Closes https://github.com/elastic/kibana/issues/152778 ### Screenshots #### Before  #### After When the integration does NOT enable TSDB:  When the integration DOES enable TSDB:  ### Steps to test locally Refer to the [original PR](https://github.com/elastic/kibana/pull/144974) for extended context. #### Testing a package without TSDB 1. Run Kibana on this branch. 2. Add the System integration (version 1.5.2 at the time of writing); under the `Collect metrics from System instances -> System cpu metrics -> Advanced options` settings, the `Time-series indexing (TSDB)` switch should be off and enabled (you should be able to toggle it on and off). #### Testing a package with TSDB 1. Update the system integration to use TSDB and run a local package registry: 1. In the integrations repo, bump the patch version of the system integration: add a changelog entry (1.25.3) and update the version accordingly in the package manifest. 2. In the manifest of the cpu data stream, add the following to enable TSDB (see [this doc](2abe6f635a/docs/developer_tsdb_migration_guidelines.md) for context): ``` elasticsearch: index_mode: "time_series" ``` 3. Build the system integration: `cd packages/system && elastic-package build` 4. Run a local package registry: `elastic-package stack up -d -v --services package-registry` 5. Check at https://localhost:8080/search?package=system that the version is correct (1.5.3). 4. Run Kibana on this branch to test the change: 1. In your `kibana.dev.yml`, add `xpack.fleet.registryUrl: https://localhost:8080` if not there already. 2. Also in `kibana.dev.yml`, add `xpack.fleet.enableExperimental: ['experimentalDataStreamSettings']` if not there already. 6. Before running `yarn start`, run `export NODE_EXTRA_CA_CERTS=$HOME/.elastic-package/profiles/default/certs/kibana/ca-cert.pem` in the same shell. This is to set up the certificate needed to access EPR with https. 7. In Kibana, add the System integration (check that the version is correct); under the `Collect metrics from System instances -> System cpu metrics -> Advanced options` settings, the `Time-series indexing (TSDB)` switch should be on and disabled. There should be a question mark icon with a tooltip. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>	2023-04-12 17:09:53 +02:00
Jill Guyonnet	14222e6f03	[Fleet] Update Fleet API doc link + remove beta badge (#154442) ... ### Summary This PR adds and updates documentation links and removes `beta` badges for the GA of Fleet API in 8.8.0. This includes the following changes: 1. Elastic Agent integration settings page, `API reference` tab: * Update the documentation link to https://www.elastic.co/guide/en/fleet/master/fleet-api-docs.html. * Remove the `beta` badge. 2. `Preview API request` flyout: * Add a link to the documentation to the title (cf. screenshots). * Remove the `beta` badge. Closes https://github.com/elastic/kibana/issues/152966 ### Screenshots #### Elastic Agent integration settings page, `API reference` tab - Before  #### Elastic Agent integration settings page, `API reference` tab - After  #### `Preview API request` flyout - Before  #### `Preview API request` flyout - After  ### Steps to test locally On this branch, start Kibana in dev. 1. Elastic Agent integration settings page, `API reference` tab: 1. Go to `<localKibanaUrl>/app/integrations/detail/elastic_agent-1.7.0/api-reference`. 2. Check that the `beta` badge is removed and that the `Learn more` link point to https://www.elastic.co/guide/en/fleet/master/fleet-api-docs.html. 2. `Preview API request` flyout: 1. Create a new agent policy: give it a name and click `Preview API request`. 2. Check that the `beta` badge is removed and that the title has a `Learn more about Fleet API` link that points to https://www.elastic.co/guide/en/fleet/master/fleet-api-docs.html. 3. Do the same checks when updating an agent policy, creating a package policy and updating a package policy. ### Checklist - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)	2023-04-12 17:05:02 +02:00
Julia Bardi	0efdf351e6	[Fleet] fix pr condition to unblock prs if available versions not available (#154808) ... ## Summary Fixing pr condition in https://github.com/elastic/kibana/pull/154649 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>	2023-04-12 07:56:54 -07:00
Sander Philipse	67308c6f8b	[Enterprise Search] Show days in crawl duration when applicable (#154824) ... ## Summary This shows the number of days in a crawl duration, if a crawl has lasted more than a day.	2023-04-12 07:51:42 -07:00
Sander Philipse	43fa6e549c	[Enterprise Search] Add filtering for search indices (#154720) ... ## Summary Adds a toggle to only show search-optimized indices to our indices page. Also splits up the fetch indices calls for our search applications and the indices page into two separate flows. <img width="1144" alt="Screenshot 2023-04-11 at 14 30 08" src="https://user-images.githubusercontent.com/94373878/231163183-21b58d58-e28e-44f2-a42e-033508e15ebd.png">	2023-04-12 07:42:25 -07:00
Angela Chuang	bada04c27b	[SecuritySolution] Fix DNS histogram query (#154548) ... ## Summary This fix below query issues within DNS histogram: ### 1. The terms aggregates field should be `dns.question.regustered_domain` instead `dns.question.domain` **Steps to verify:** - Inspect the chart and observe the query should do terms aggregation on `dns.question.regustered_domain` **Known issue:** https://github.com/elastic/kibana/issues/154533 <img width="1673" alt="Screenshot 2023-04-06 at 12 40 38" src="https://user-images.githubusercontent.com/6295984/230366661-bb9ce5d3-7e80-460e-af64-8fbe26521c1c.png"> ### 2. It didn't respect `is PTR record included` flag **Steps to verify:** - Switch the toggle in DNS tab to `include PTR record` - Inspect the chart and observe the query should not exclude PTR record - Click on Add to new Case / Add to existing Case / Open in Lens and observe the query should not exclude PTR record. https://user-images.githubusercontent.com/6295984/230366687-8cf0a4dd-beca-46ef-b756-ce898f289c47.mov ### 3. It didn't respect `is PTR record included` when feature flag `chartEmbeddablesEnabled: is false` **Steps to verify:** - Set chartEmbeddablesEnabled to false - Switch the toggle in DNS tab to `include PTR record` - Click on Add to new Case / Add to existing Case / Open in Lens and observe the query should not exclude PTR record. https://user-images.githubusercontent.com/6295984/230420883-a1541d91-7414-4ce8-9ef5-ffb00e7d174d.mov **After:** https://user-images.githubusercontent.com/6295984/230366882-3fe857b0-b3d6-46cf-aaa7-646190ae661f.mov ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios	2023-04-12 15:14:56 +01:00
Nick Peihl	fe3f9ac4fe	[Maps] Enable skipped test (#154760) ... ## Summary This test was failing due to a transient network issue caused by an unexpected certificates rotation on Elastic Maps Service. Fixes #153960 [Flaky test runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2109)	2023-04-12 09:59:03 -04:00
Coen Warmer	9ac09b2cf1	Add Hideable React Query Dev Tools (#154817)	2023-04-12 06:45:45 -07:00
Kevin Logan	665c9dd690	[Security Solution] Skip Defend Workflows Cypress tests due to package installation issue (#154813) ... ## Summary Skipping additional cypress tests due to ES promotion issue here: https://github.com/elastic/kibana/issues/154741 Will re-enable once ES issue is resolved. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios	2023-04-12 08:44:55 -05:00
Sloane Perrault	54f8ca1a33	[Enterprise Search] Search Apps. - add popover to disabled button (#154769) ... ## Summary https://user-images.githubusercontent.com/1699281/231268612-a94fbd46-19bd-407d-a75c-576313843792.mov ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)	2023-04-12 09:18:02 -04:00
Ignacio Rivas	aefc949911	[Ingest Pipelines] Add license checks for processors (#154525)	2023-04-12 14:28:51 +02:00
Marco Liberati	dd083a351a	[Lens] Minor stylistic fixes (#154321) ... ## Summary Fixes #152523 and a dropdown menu color issue raised in https://github.com/elastic/kibana/pull/151749#pullrequestreview-1367099460 For the help popover: <img width="477" alt="Screenshot 2023-04-04 at 11 40 04" src="https://user-images.githubusercontent.com/924948/229760378-8b83e454-b81f-4450-a6e2-5cac6860d274.png"> <img width="495" alt="Screenshot 2023-04-04 at 11 49 02" src="https://user-images.githubusercontent.com/924948/229760393-957c00cf-4311-4973-8b2f-99f85b13d126.png"> Unfortunately the bonus point cannot be achieved as the `EuiListGroupItemExtraAction` component only offers an `hover` | `alwaysShow` options: https://elastic.github.io/eui/#/display/list-group As for the layer dropdown menu: <img width="374" alt="Screenshot 2023-04-04 at 12 08 34" src="https://user-images.githubusercontent.com/924948/229760921-5b43c017-8d16-4e1d-9b2d-521040fdd5ed.png"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes&mdash;Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>	2023-04-12 14:11:35 +02:00
Kevin Delemme	0825e96d23	feat(slo): Add tooltips in creation form (#154766)	2023-04-12 08:02:02 -04:00
jennypavlova	5a03c5d710	[Infrastructure UI] Hosts view flyout metadata search (#154556) ... Closes #154347 ## Summary This PR adds search functionality to the metadata tab. In order to optimize the search I changed the table to `EuiInMemoryTable` and handled the search there. One benefit is that table filtering is the responsibility of the table and the cases to handle errors/no data found are much easier. <img width="2435" alt="Screenshot 2023-04-06 at 15 36 35" src="https://user-images.githubusercontent.com/14139027/230400195-b77b7783-9c4d-48b0-85e6-cb38180a29d3.png"> <img width="2434" alt="Screenshot 2023-04-06 at 15 58 22" src="https://user-images.githubusercontent.com/14139027/230400337-1013626c-c802-4b45-88f1-bff67f0ec37e.png"> This also helped to get rid of some of the callouts condition and leave the table component to decide what to render based on the items and loading state. That way the loading looks much smoother rather than replacing the table with a loading component - also when loading and there are no results the loading indicator is inside the table.  ## Testing 1. Open the flyout for a single host 2. On the metadata tab start searching a. Try to search for field name/value - should get a result b. Do a typo with an invalid character (or just enter only ```, `+`, etc) - an error message should be displayed (and ⚠️ icon in the search bar) c. Try to search for something that it's not a field name/value - should display the `No metadata found.` message in the table. 3. Copy a URL after searching for something and paste it into a new browser tab/window - it should persist the search term. (In case of a search error the search filter is not persisted) https://user-images.githubusercontent.com/14139027/230400149-6ba4dc32-efaa-4068-8abb-24b6ae43de76.mov	2023-04-12 13:49:56 +02:00
Joseph McElroy	57d6f413a1	[Behavioral Analytics] Add api key modal in integration page (#154738) ... Add API Key modal to integration page. <img width="812" alt="Screenshot 2023-04-11 at 16 13 40" src="https://user-images.githubusercontent.com/49480/231208531-920272be-bd48-4bb0-971d-c740a2e8b2e2.png"> <img width="882" alt="Screenshot 2023-04-11 at 16 13 46" src="https://user-images.githubusercontent.com/49480/231208527-d8fb2a41-ad9c-4fd3-b7c9-a1cd1de7fe02.png"> <img width="820" alt="Screenshot 2023-04-11 at 16 13 53" src="https://user-images.githubusercontent.com/49480/231208520-e9ec8ae3-e3a7-4dc3-8e6b-f6f339e9f084.png"> <img width="991" alt="Screenshot 2023-04-11 at 16 13 59" src="https://user-images.githubusercontent.com/49480/231208512-791f6a8c-e8ad-4960-840c-8a2bea5ab556.png"> --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>	2023-04-12 12:02:48 +01:00
Yan Savitski	0790ec0da2	[Enterprise Search] [Behavioral analytics] Create dashboard details tables (#154790) ... ✅ Created logic for fetch explore items ✅ UI for tables ✅ Add tables 'Popular search terms', 'Worse performers', 'Top clicked results', 'Top referrers' <img width="1296" alt="image" src="https://user-images.githubusercontent.com/17390745/231310342-2bc9b776-362e-4d8c-bd1c-0944e94216c9.png"> <img width="1296" alt="image" src="https://user-images.githubusercontent.com/17390745/231310360-831d4f6c-feab-4b94-9d8c-67218d6b0557.png"> <img width="1296" alt="image" src="https://user-images.githubusercontent.com/17390745/231310408-92bda734-6783-433d-a752-99025c30c446.png">	2023-04-12 11:54:47 +02:00
Marco Liberati	41170fe64b	[Lens] Enable report sharing (#153429) ... ## Summary Fixes #130438 This PR introduces the PNG/PDF reporting feature within Lens editor. **Note** each reporting tasks is generating a shortURL SO in addition of the reporting job SO. There's a reusing mechanism but it applies only to the same config within the same session. * [x] Enable reporting for ~~`lens_visualization` type~~ `lens` type * [x] Introduce disabled state within the reporter logic * [x] Extends the logic to support the custom URL types in Lens * [x] Make reporting list page to support `lens_visualization` object type * migrated `lens_visualization` to `lens` and used the app icon * [x] Extends the custom CSS styling to handle specific Lens editor layout * [x] Introduce logic for `renderComplete` within the Lens editor * [x] Loading logic * [x] Trigger `renderComplete` event for the right node * [x] Add `.hide-for-sharing` class where needed * [x] Add the `.stretch-for-sharing` where needed * Improve layout settings to have a better fit of some charts * Maybe this can be addressed as separate issue? * Check the `renderComplete` for the RegionMap external plugin => separate issue * Write tests * [x] Functional tests Reporting page: <img width="1255" alt="Screenshot 2023-03-24 at 15 25 12" src="https://user-images.githubusercontent.com/924948/227552385-1b52a0ae-8902-4972-acf3-323093a7b840.png"> **Note**: at the moment the reporting name follows the CSV naming convention of `unsaved` for unsaved Lens visualizations. The legacy Agg-based editor uses instead a namming pattern as follow: `Visualization <timestamp>.png`. Final results: | Chart type | PNG result | | ------ | ----- | | Stacked bar chart |  | | Vertical bar chart |  | | Horizontal stacked bar chart |  | | Horizontal bar chart |  | | Datatable |  | | Horizontal gauge |  | | Vertical gauge |  | | Legacy metric |  | | Metric |  | | Metric with breakdown |  | | Area chart |  | | Line chart |  | | Bar chart with annotation + reference lines |  | | Heatmap |  | | Donut chart |  | | Pie chart |  | | Treemap |  | | Mosaic |  | | Waffle |  | | Region Map |  | ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces&mdash;unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes&mdash;Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>	2023-04-12 09:38:29 +02:00
Kibana Machine	6365d54d06	[api-docs] 2023-04-12 Daily api_docs build (#154794) ... Generated by https://buildkite.com/elastic/kibana-api-docs-daily/builds/305	2023-04-12 00:48:12 -04:00
Jonathan Buttner	f111d93d08	[Cases] Adding cases settings docs (#154672) ... This PR adds the new configuration settings to the docs. The configurations were added in this PR: https://github.com/elastic/kibana/pull/154013 --------- Co-authored-by: lcawl <lcawley@elastic.co>	2023-04-11 22:15:26 -04:00
Cauê Marcondes	2f001a2f8d	[Profiling] Space-specific feature privileges (#154734)	2023-04-11 20:35:48 -04:00