Commit graph

16254 commits

Author SHA1 Message Date
Nathan Reese
e8dc6736df
make react route finer grained so other apps don't route to home page while angular is routing to those apps (#15059) (#15062) 2017-11-20 17:02:56 -07:00
Spencer
09e582f82d
[6.x] [precommit hook] add dev script (#14890) (#15065)
* [precommitHook] move to dev script

* [eslint] fix lint error

* [dev/eslint] do simply boolean checks first

* [dev] use shared REPO_ROOT constant

* [dev/File] precompute relative/ext of path

* [dev/eslint] fix relative import

* [dev/eslint] fix typos

* [grunt] remove unused run:eslintStaged config

* [dev/run] only create log if we are going to use it

* [dev/run/isFailError] ensure return value is Boolean

* [dev/precommitHook] use less intermediate vars
2017-11-20 17:00:37 -07:00
Stacey Gammon
3a7b2f52be
Reactify full screen mode placeholder and remove from scope (#14886) (#15061)
* Reactify full screen mode placeholder and remove from scope

With the toggle in react, no need to store it on scope.

* Simplify implementation by bringing in chrome.setVisible internal to the react placeholder

* rename FullScreenModePlaceholder => ExitFullScreenButton

* div => KuiButton

* Add jest tests for exit full screen button

* Use native Object.values.map instead of loadash _.map

* get rid of unnecessary return value
2017-11-20 15:40:42 -05:00
Stacey Gammon
2a4600f84a
ensure time picker open in retry loop (#15034) (#15054)
* ensure time picker open in retry loop

* clean up isTimepickerOpen to use testSubjects.exists
2017-11-20 10:53:40 -05:00
Stacey Gammon
82bcf81026
[6.x] Add debounce to visualize search filter so we don't send a request on every character press (#15039)
* Fixes https://github.com/elastic/kibana/issues/14908 (#15003)

* Cancel debounce when component unmounts

* remove trailing whitespace

* Remove more trailing whitespace
2017-11-20 08:38:34 -05:00
Peter Pisljar
9a0b6b589f removing failing tilemap tests (#15048) 2017-11-20 13:18:46 +01:00
Stacey Gammon
dbe7b0c4c7
Fix mistakes added in bwc url test PR (#15038) (#15041)
* Fix mistakes in bcc tests

* Correct data-test-subj name
2017-11-17 20:06:04 -05:00
Nathan Reese
9a7e9f1a51
Set timeout and terminate_after parameters when fetching terms for Input Controls (#14977) (#15040)
* set parameters like suggestions api

* provide timeout and terminate_after in initial state instead of using search_source set

* remove shard_size param and add comment about needed to replace searchsource with suggestions API
2017-11-17 17:08:51 -07:00
Stacey Gammon
3783e41664
Add BWC url tests for 6.0 (#15033) (#15036)
Also adds some stabilization by refactoring some retries and
expectations.
and fixes a bug that snuck in between two PRS where the pie slice css
changed.
2017-11-17 18:06:42 -05:00
Stacey Gammon
b842651c9e
[6.x] Add a couple tests with queries and saved searches linked to visualizations (#14878) (#15025)
* Add a couple tests with queries and saved searches linked to visualizations (#14878)

* Add a couple tests with queries and saved searches linked to visualizations

Fix issue when edit link is clicked too soon and embeddable hasn't finished loading

* attempt to fix flakiness

* remove duplicate lines

* Use the correct pie slice css
2017-11-17 16:04:03 -05:00
Spencer
c75698d83e
[6.x] [ftr] default window size (#14834) (#15032)
* [ftr/mocha] revert Mocha UI assigments after loading test files

* [ftr] add beforeTopLevelSuite and afterTopLevelSuite lifecycle hooks

* [ftr] add defaultWindowWidth and defaultWindowHeight options

Adds two configuration parameters to the functional test runner which
will set the windowSize before running the tests in any file and
restores the original window size when the tests complete.

Individual test files can set the windowSize within its own before() or
beforeEach() handlers using the same `command.setWindowSize()` command.

* [ftr/assignmentProxy] use better naming

* [ftr] restore initial window size after each suite

* [ftr] improve error message for unexpected suite definitions

* [ftr/remote] remove configuration option, rely on suite-level changes

* [ftr] fix stack manipulation order

* [ftr/remote] write tests for window size management
2017-11-17 13:13:00 -06:00
Nathan Reese
0381286b63
give info msg instead of error msg when no default index pattern (#15010) (#15028)
* give info msg instead of error msg when no default index pattern

* fix tests

* use _.get instead of _.has plus turnary operator
2017-11-17 09:44:59 -07:00
Tim Roes
638e0d3c62
[Accessibility] Load angular-aria for kibana module (#14969) (#15015)
* Load angular-aria for kibana module

* Fix indentation

* Add documentation
2017-11-17 13:52:43 +01:00
Tim Roes
f26f5e0901
Remove ready:vis and application.load event (#14988) (#15017)
* Remove ready:vis event

* Remove application.load event

* Remove commented code

* Fix comment

* Fix broken indentation
2017-11-17 12:20:05 +01:00
Peter Pisljar
0b5052aac2
pie chart labels (#12174) (#15016)
* pie labels

* add simple unit test

* fixing dashboard test

* fixing basedo on review

* simplifying conflict resolution

* removing unused code

* cleanup code

* minor changes based on review

* updating option templates to match new design

* updating truncate_labels to work with chars instead pixels
2017-11-17 12:13:08 +01:00
Nathan Reese
a0698b96b3
[timelion] trim number of colors when there are more colors than gradient stops (#14906) (#15007)
* trim number of colors when there are more colors than gradient stops

* simplify if/else logic as suggested by timroes
2017-11-16 19:57:20 -07:00
Stacey Gammon
23c6106065
Add a feature for custom panel titles (#14831) (#15004)
* Add a feature for custom panel titles

* Add tests and put back data-test-subjs

* sync with master and add padding to form

* UI/UX cleanup

- add enter on close functionality
- make reset title a link instead of a button
- Push css to visualizations instead of the panel. This means
background colors will be flush to the panel.  Override for tile maps
which apparently need it (yet region maps don’t for some reason??)

* Fix refactor miss from merge

* whoops, put block display back to make link fall to bottom

* Undo accidental delete visualization name change

* Color top pop over arrow correctly

* Use naming Options and Customize Panel

* update jest snapshot

* Use custom panels for data-title attributes
2017-11-16 15:56:29 -05:00
Chris Roberson
3d68d3ffeb
[Management] Ensure non alphanumeric characters do not affect index pattern searching (#14973) (#14999)
* - Fix issue with non alphanumeric characters affecting index pattern search
- Restructure and add tests

* More tests
2017-11-16 14:07:59 -05:00
Kim Joar Bekkelund
8938dd2193
Revert "Remove 401 error wrapping (#14324)" (#14996) (#14998)
This reverts commit f167a00543.
2017-11-16 17:38:59 +01:00
Nathan Reese
03fa43ebbd
[home] feature directory - make icon and description be part of href (#14947) (#14987)
* make icon and description be part of feature href

* do not change background color - just underline title
2017-11-16 08:58:04 -07:00
Kim Joar Bekkelund
5e04d5feee
Remove 401 error wrapping (#14324) (#14989) 2017-11-16 14:11:51 +01:00
Brandon Kobel
b5e1708bf8
Sharing - Preserve Layout (#14707) (#14990)
* Adding method to expose the dashboard app container size to reporting

* Adding a data-shared-items-container attribute to the viewport

* Making visualize tell us how large they are

* Removing the controller methods that returned the item size

* Moving the sharing attributes to be on the actual elements, so we can
figure out their dimensions

* Passing the savedObj to the Visualize elements adding the data- attrs

* Adding the title/description to the Dashboard

* Dispatching the initial title/description

* Reverting some accidental whitespace changes

* Fixing metadata selectors

* Adding newline at end of file...

* Putting the $emit('renderComplete') back

* Passing only the savedObj to the Visualize Editor Controller

* Setting the description on the $scope.vis so we don't have to pass the
SavedObj

* Reverting more TSVB title/description code

* Removing savedObj from scope

* Putting $scope.vis back to vis
2017-11-16 08:10:24 -05:00
CJ Cenizal
cf8b93180f
Add (MIT AND Zlib) to acceptable licenses. (#14985) (#14986) 2017-11-15 17:14:15 -08:00
lcawley
a2976008a2 [DOCS] Moved X-Pack Breaking Changes section 2017-11-15 16:16:04 -08:00
Lisa Cawley
cb91c1ab99 [DOCS] Remove X-Pack release note reference (#14983) 2017-11-15 16:01:33 -08:00
CJ Cenizal
54897612ab
Fix some accessibility coloring issues (#14972) (#14981)
Fixes table contract and some discover contrast issues.
2017-11-15 14:46:59 -08:00
Tyler Smalley
9ba63d1b1a
Revert "[docs] Enforce a single type for migrated Kibana index (#14884) (#14962)
index.mapping.single_type is only available in 5.6
2017-11-15 13:28:58 -08:00
Stacey Gammon
1f333d00ff
Stop listening for ready:vis to fetch from courier (#14848) (#14965)
* Stop listening for ready:vis to fetch from courier

This means saved searches will get requested in their own msearch but
this actually improves dashboard loading because waiting on saved
searches can slow down a whole dashboard.  Splitting up visualizations
from saved searches is an improvement and it cleans up the code, so I
think we should do this.

* Push courier.fetch into search_embeddable_handler
2017-11-15 15:53:30 -05:00
Tim Roes
188a972513
[Accessibility] Refactor font slider for accessibility (#14817) (#14961)
* Refactor font slider for accessibility, fix #12905

* Limit input fields min/max values

* Prevent crossing of min/max values

* Revert "Prevent crossing of min/max values"

This reverts commit 575dfac0b5.

* Use UI framework classes
2017-11-15 17:07:31 +01:00
Nathan Reese
4f39715650
Timelion typeahead for argument values (#14801) (#14958)
* timelion argument value suggestions for legend function

* update functions with argument value suggestions

* use async/await instead of promise resolve/reject for suggestion generation

* lookup value suggestions for es index and timefield arguments

* custom handlers for es metric and split arguments

* update suggestions unit test

* remove duplicate code from insertSuggestion switch

* refactor arg_value_suggestions to provide three methods instead of single getSuggetions method

* template literal

* update es index argument desc to include note about type ahead support
2017-11-15 08:15:34 -07:00
Kim Joar Bekkelund
231f619073
Remove circular dep from concat_stream (#14847) (#14866) 2017-11-15 10:41:54 +01:00
Spencer
98a1c5a0f1
[6.x] Upgrade to eslint 4 (#14862) (#14951)
* [eslint] upgrade to 4.10.0

* [eslint-config-kibana] limit jest config to jest test files

* [ui_framework] remove trailing comma from rest-spreads

* [dashboard/tests] tag jest helpers with .test.js suffix

* explicitly import expect.js where used

* [eslint] apply auto-fixes

* [eslint] manually add/wrap some parens for compliance

* [npm] point to local packages for testing/review

* [jest] remove .test extension from jest helpers

* [ui_framework] fix trailing comma removal from 3bc661a1c8

* [packages] upgrade eslint packages
2017-11-14 20:20:37 -07:00
Spencer
242c6fae2e
[6.x] [eslint] add eslint dev script (#14889) (#14941) 2017-11-14 10:24:00 -07:00
Tyler Smalley
81b9e727bd Removes index.mapper.dynamic from test fixture (#14930)
This was removed in ES 6.0+

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-11-14 07:26:14 -08:00
Jonathan Budzenski
1cd87ef246
[6.x] [ci] Build docs (#14868)
* [ci] Build docs (#14130)

* [ci] Build docs

* fix context

* remove docs task from jenkins:unit

* [jenkins] Add docs script (#14769)

* [jenkins] Add docs script

* remove xvfb
2017-11-14 09:16:16 -06:00
lcawley
939d08c7bc [DOCS] Fixed broken link in tilemap.asciidoc 2017-11-13 19:47:45 -08:00
Court Ewing
f5ea01d97d
docs: list breaking change sections (#14932) 2017-11-13 20:59:17 -05:00
Court Ewing
628d0cd194 docs: fix erroneous references to es-ref 2017-11-13 20:26:32 -05:00
Court Ewing
116ed38a14
docs: 6.0.0 release notes (#14927) 2017-11-13 20:13:25 -05:00
Tyler Smalley
6355b12a46
[docs] Enforce a single type for migrated Kibana index (#14884)
This prevents users from using tools which insert dashboards/visualizations directly into the index, which would cause Kibana to stop functioning.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-11-13 14:39:44 -08:00
Alex F
a6fe72efb6
Details in Kibana types 2017-11-13 16:00:22 -05:00
Matt Bargar
b20e31fe11
Deprecate expression based scripted fields (#14281)
This PR adds deprecation messages in two places in the Kibana UI. The first is the scripted field creation page, where a message is shown if you've chosen a deprecated language for your script. The second is the index pattern scripted field list page, where a message is shown if any existing scripted fields use a deprecated language. It also adds an error message to the list page if a completely unsupported language is detected.
2017-11-13 15:40:29 -05:00
Chris Roberson
076cea1694
[Management] Address UI searching bug with index pattern creation (#14646) (#14922)
* Move this logic to a separate directive. Also fix a couple bugs with it around how it interacts with angular.

* Updated variable name

* Handle some edge cases and simplify code

* Fixing typo and further simplyfing code
2017-11-13 15:29:24 -05:00
Tyler Smalley
3dff020add Adds keystore for securely storing settings (#14714)
Introduces bin/kibana-keystore providing create, list, add, and remove actions.

Settings stored within the keystore will be loaded at runtime.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-11-13 10:25:33 -08:00
Stacey Gammon
7b9eb6da7b
fix console warning about missing required prop (#14876) (#14897) 2017-11-11 08:10:51 -05:00
Jonathan Budzenski
f02f77fe43
[console] assorted autocomplete fixes (#14770)
* [console] add miminum_should_match to match query

* [console] source include,exclude -> includes,excludes

* [console] Remove lowercase expanded terms

* [console] _source_{include,exclude} -> _source_{includes,excludes}

* [console] autocomplete for rollover api

* [console] autocomplete for extended_bounds
2017-11-10 12:27:37 -06:00
CJ Cenizal
49aa2f2063
Fix Jest warnings for ConfirmModal. (#14892) (#14902) 2017-11-10 09:04:28 -08:00
Tim Roes
544e84b917
Fix broken date range look, fix #12731 (#14837) (#14900) 2017-11-10 17:47:14 +01:00
Tim Roes
6996d0599b
Fix issue, where tags are vanishing after double resize (#14822) (#14899)
* Fix issue, where tags vanishing after resizing

* Also fix rawText in debug log
2017-11-10 17:46:53 +01:00
Stacey Gammon
d813d99caa
Add new title query param to dashboard listing page (#14760) (#14880)
* introduce a mechanism to load a dashboard by title is a single one is found, if not, to refill the search box on the listing page

* Make case insensitive and prevent listing page from "blipping" up on the screen before the redirect

* Add tests
2017-11-09 17:06:30 -05:00