Commit graph

14635 commits

Author SHA1 Message Date
Matthew Bargar
48c3da71b9 Align better with ES doc structure 2016-10-20 18:54:09 -04:00
spalger
d1e53cf615 [fieldFormats/colors] escape style values 2016-10-20 15:40:04 -07:00
Court Ewing
a5080ee76b Merge pull request #8787 from elastic/jasper/backport/8785/5.x
[backport] PR #8785 to 5.x - [server/logging] intercept ECONNRESET messages and downgrade them
2016-10-20 17:34:46 -04:00
Elastic Jasper
6326821da1 Backport PR #8785
---------

**Commit 1:**
[server/logging] intercept ECONNRESET messages and downgrade them

* Original sha: 38bcad9a05
* Authored by spalger <email@spalger.com> on 2016-10-20T19:24:16Z

**Commit 2:**
[server/logging] remove doTagsMatch() helper

* Original sha: a8eea585d5
* Authored by spalger <email@spalger.com> on 2016-10-20T20:19:33Z

**Commit 3:**
[server/logging] add tests for log interceptor

* Original sha: 866abcc820
* Authored by spalger <email@spalger.com> on 2016-10-20T20:35:35Z

**Commit 4:**
[server/logging] only match tags that are in the right order

* Original sha: 1973ed8a91
* Authored by spalger <email@spalger.com> on 2016-10-20T20:50:26Z

**Commit 5:**
[server/logging] remove unused dependency

* Original sha: dbe5f6fb72
* Authored by spalger <email@spalger.com> on 2016-10-20T20:58:59Z

**Commit 6:**
[server/logging] fix the order we expect tags to be in

* Original sha: 76e09e6740
* Authored by spalger <email@spalger.com> on 2016-10-20T21:04:58Z
2016-10-20 17:13:03 -04:00
Court Ewing
2ca0c19603 Merge pull request #8780 from elastic/jasper/backport/8778/5.x
[backport] PR #8778 to 5.x - [timelion] Remove saved sheets link
2016-10-20 11:36:00 -04:00
Elastic Jasper
8e5a9dd37a Backport PR #8778
---------

**Commit 1:**
[timelion] Remove saved sheets link
Currently saved timelion sheets are not showing up in the saved objects page, so the link errors and loads a blank page

* Original sha: 19e5af9f6e
* Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-10-20T14:29:15Z
2016-10-20 11:13:53 -04:00
Court Ewing
d7957a5f1b Merge pull request #8776 from elastic/jasper/backport/8775/5.x
[backport] PR #8775 to 5.x - Disabling the uiSettings for the cli_plugin install
2016-10-20 10:39:44 -04:00
Elastic Jasper
4561162d8f Backport PR #8775
---------

**Commit 1:**
Disabling the uiSettings for the cli_plugin install

* Original sha: 81ff2eb639
* Authored by = <brandon.kobel@elastic.co> on 2016-10-20T14:18:17Z
2016-10-20 10:32:11 -04:00
Spencer
07b6453720 Merge pull request #8770 from elastic/jasper/backport/8764/5.x
[backport] PR #8764 to 5.x - UI Settings should be disabled when elasticsearch is not available
2016-10-19 17:18:27 -07:00
spalger
13432d3084 [server/uiSettings] remove trailing space
(cherry picked from commit 6865281a59)
2016-10-19 17:01:02 -07:00
Elastic Jasper
533ac981f5 Backport PR #8764
---------

**Commit 1:**
UI Settings disabled when plugins.initialize is false

* Original sha: c6f90e2fd3
* Authored by = <brandon.kobel@elastic.co> on 2016-10-19T20:47:05Z

**Commit 2:**
Moving where we're disabling the ui settings

* Original sha: e66c7e79f9
* Authored by = <brandon.kobel@elastic.co> on 2016-10-19T21:22:52Z

**Commit 3:**
[server/uiSettings] add enabled config

in response to matt's comment that relying on `plugins.initialize` is kinda dirty (with which we all agree) we're adding an undocumented config value that the dev cli can use to put prevent the optimizr server from logging meaningless warnings

* Original sha: 40ffd12238
* Authored by spalger <email@spalger.com> on 2016-10-19T23:24:55Z

**Commit 4:**
[server/uiSettings] react to missing elasticsearch plugin

* Original sha: 7feacf6a70
* Authored by spalger <email@spalger.com> on 2016-10-19T23:26:44Z

**Commit 5:**
[server/uiSettings] fix da tests

* Original sha: c2d7d0136a
* Authored by spalger <email@spalger.com> on 2016-10-19T23:36:11Z

**Commit 6:**
[server/uiSettings] document enabled config

* Original sha: f9bd154fcd
* Authored by Spencer <spalger@users.noreply.github.com> on 2016-10-19T23:52:28Z
* Committed by GitHub <noreply@github.com> on 2016-10-19T23:52:28Z
2016-10-19 19:52:59 -04:00
Matt Bargar
5b22d28cb0 Merge pull request #8759 from elastic/jasper/backport/8740/5.x
[backport] PR #8740 to 5.x
2016-10-19 16:49:09 -04:00
Spencer
2c0a221cf0 Merge pull request #8761 from elastic/jasper/backport/8758/5.x
[backport] PR #8758 to 5.x - Internal server error when saving a widget with German characters in name
2016-10-19 13:37:11 -07:00
Elastic Jasper
afbc7909a2 Backport PR #8758
---------

**Commit 1:**
URI-encode forwarded location header in proxy

Right now there are situations in which ElasticSearch puts characters in
the character code range between 128 and 255 into the `Location` header.
This leads to an exception when trying to pass on that header through
the hapi proxy in versions before 15.0.0, because it validates that only
US-ASCII characters are used in headers.

To work around that situation, the `Location` header is encoded using
`encodeURI()` for now.

Closes #8705

* Original sha: 18c23c17d9
* Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-18T17:55:31Z

**Commit 2:**
Add test to verify umlaut in vis name

Relates to #8705

* Original sha: e100e1f5c9
* Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-19T09:01:46Z

**Commit 3:**
[elasticsearch/proxy] use different code path with erorr

* Original sha: fec5e1a2dc
* Authored by spalger <email@spalger.com> on 2016-10-19T19:06:39Z
2016-10-19 15:25:13 -04:00
Brandon Kobel
1171461c2d Merge pull request #8757 from elastic/jasper/backport/8746/5.x
[backport] PR #8746 to 5.x
2016-10-19 15:10:40 -04:00
Elastic Jasper
c248419ef1 Backport PR #8740
---------

**Commit 1:**
Generate key for ip range from/to agg

Elasticsearch 5.0 no longer returns a `key` prop with ip range buckets
when from/to is used in the request. Looking at the [2.x docs][1] it
appears to be a mistake that it was ever included in the first place.
So now we'll generate the key ourselves.

[1]: https://www.elastic.co/guide/en/elasticsearch/reference/2.4/search-aggregations-bucket-iprange-aggregation.html

Fixes: https://github.com/elastic/kibana/issues/8736

* Original sha: f344a4b262
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T22:51:56Z

**Commit 2:**
Stop sending null in ip range from/to props

The IP range agg supports open ended ranges. Elasticsearch 2.x was
lenient and accepted null as a value for the from/to props, but the
correct way to do an open ended range was always to omit the from/to
key entirely. ES 5.0 appears to be more strict and barfs when null is
passed. This commit removes the null values.

Fixes https://github.com/elastic/kibana/issues/8741

* Original sha: 3ca45ba546
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T23:18:14Z

**Commit 3:**
ip range label and filter improvements

* updated the filter labels to match the range labels
* fixed the filter creation to work for unbound ranges

* Original sha: b153ea0da3
* Authored by Spencer <spalger@users.noreply.github.com> on 2016-10-19T17:57:58Z
* Committed by Matthew Bargar <mbargar@gmail.com> on 2016-10-19T18:36:22Z
2016-10-19 15:10:17 -04:00
Spencer
b4521f5e15 Merge pull request #8729 from elastic/jasper/backport/8717/5.x
[backport] PR #8717 to 5.x
2016-10-19 11:54:19 -07:00
Elastic Jasper
32cbd7cee9 Backport PR #8746
---------

**Commit 1:**
Printing process warning's via the appropriate logger

* Original sha: 96ef75b980
* Authored by = <brandon.kobel@elastic.co> on 2016-10-19T10:41:45Z
2016-10-19 14:51:15 -04:00
Court Ewing
91aecc2a8f Merge pull request #8742 from elastic/jasper/backport/8733/5.x
[backport] PR #8733 to 5.x - Bump node to 6.9.0
2016-10-18 20:15:23 -04:00
Elastic Jasper
10dc033c89 Backport PR #8733
---------

**Commit 1:**
Bump node to 6.9.0

* Original sha: 26a0be8caa
* Authored by Jonathan Budzenski <jon@jbudz.me> on 2016-10-18T18:40:06Z
2016-10-18 20:06:12 -04:00
Elastic Jasper
6c2a8068a5 Backport PR #8717
---------

**Commit 1:**
[aggConfig] use `getField`/`getFieldDisplayName` helpers

* Original sha: 0190cda30e
* Authored by spalger <email@spalger.com> on 2016-10-17T20:21:08Z

**Commit 2:**
[aggParams/field] throw better error when field missing

* Original sha: 1ee969c97a
* Authored by spalger <email@spalger.com> on 2016-10-17T20:33:26Z

**Commit 3:**
[tests] update tests that depended on `aggConfig#field()`

* Original sha: 51cc35b605
* Authored by spalger <email@spalger.com> on 2016-10-17T21:26:31Z

**Commit 4:**
[aggTypes/percentile] fix reference to aggConfig.fieldDisplayName()

* Original sha: ae3223262b
* Authored by spalger <email@spalger.com> on 2016-10-18T02:06:27Z
2016-10-17 22:14:44 -04:00
Matt Bargar
39a4f3bd90 Merge pull request #8722 from elastic/jasper/backport/8721/5.x
[backport] PR #8721 to 5.x
2016-10-17 18:58:04 -04:00
Elastic Jasper
e7e228f1ff Backport PR #8721
---------

**Commit 1:**
Stop Discover's Visualize button from loading incorrect URL

When App state is read from the url, it is accessed via
`$location.search()`. It turns out that the result of
`$location.search()` is a mutable object that allows you to modify the
results of `$location.search()` without actually modifying the URL. When
a user clicks a field in the Discover sidebar, it executes the scope
method `vizLocation` to get the href value for the "Visualize" button.
As an unintended side effect, `vizLocation` was modifying the object
returned from `$location.search()`. This change would ultimately be read
when the Visualize app loaded instead of the param in the actual URL
since there's no full page load from Discover -> Visualize.

To make things more complicated, I believe there was a race condition
partially masking this issue. Since `vizLocation` is used in an Angular
string template, the data binding causes it to execute on every digest
cycle. This is why the incorrect value continued to be written to
`$location.search()` even after `visLocation` ran for the correct field.
It also meant that the result of `$location.search()` was totally
dependent on which field `vizLocation` ran for most recently before the
user clicked Visualize.

Fixes https://github.com/elastic/kibana/issues/8718

* Original sha: d0d926b8a9
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-17T21:07:11Z
2016-10-17 18:11:05 -04:00
Matt Bargar
325d2ec12f Merge pull request #8720 from elastic/jasper/backport/8694/5.x
[backport] PR #8694 to 5.x
2016-10-17 17:41:48 -04:00
Spencer
6619b44509 Merge pull request #8713 from elastic/jasper/backport/7990/5.x
[backport] PR #7990 to 5.x - Display the conflicting field types of an index pattern
2016-10-17 14:03:43 -07:00
Elastic Jasper
6874f1b4ca Backport PR #8694
---------

**Commit 1:**
Conditionally show Visualize button based on aggregatable status

* Original sha: 76c2687e86
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-14T22:23:37Z

**Commit 2:**
Switch to ng-show so controller can maintain reference to Visualize button and remove it upon toggle

* Original sha: 9da6ddfd16
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-17T17:21:11Z

**Commit 3:**
Add visualizable flag to field object

* Original sha: 75a2f2356d
* Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-17T17:39:13Z
2016-10-17 17:03:22 -04:00
Lukas Olson
602f897196 [console] Fix copy as curl button 2016-10-17 13:56:26 -07:00
Stacey Gammon
cc512d04c4 Merge pull request #8715 from elastic/jasper/backport/8691/5.x
[backport] PR #8691 to 5.x
2016-10-17 15:38:47 -04:00
Elastic Jasper
7ef0a47069 Backport PR #8691
---------

**Commit 1:**
Ensure boolean scripted field values are of boolean type

they come back from the server as ‘true’ currently.  Hopefully that
will be fixed in the future, so to future-proof this I am only
converting when the value is not of type boolean.

Fixes #8677

Need to convert both number and bool strings to their respective types.

Throw an error for unexpected types/values.

* Original sha: 7b8ff74513
* Authored by Stacey Gammon <gammon@elastic.co> on 2016-10-14T19:50:23Z
2016-10-17 15:21:57 -04:00
Elastic Jasper
a407c7e8c5 Backport PR #7990
---------

**Commit 1:**
Add indicies and type information for conflict field

Fixes #7661

Added indicies and type information when hover over field with conflict type in
index patterns page.

* Original sha: f842f65faf
* Authored by Martin Hickey <martin.hickey@ie.ibm.com> on 2016-08-12T12:35:01Z

**Commit 2:**
Update to display the conflict information on the edit field page

Fixes #7661

Moved content to the edit field page from the tooltip for better scalability when large data.
The conflict description data is now only stored for conflicting fields.

* Original sha: 0af13831d5
* Authored by Martin Hickey <martin.hickey@ie.ibm.com> on 2016-09-08T16:15:19Z

**Commit 3:**
Update the conflict data to show all index names per type

Fixes #7661

Feedback from review is that it would be better to display a list of indices
for each field type as would be easier to distinguish the outliers in this
case.

* Original sha: ee698c4f0b
* Authored by Martin Hickey <martin.hickey@ie.ibm.com> on 2016-09-16T15:14:57Z

**Commit 4:**
Update the alert to a warning icon

Fixes #7661

Feedback in review as follows:
For such a large section, I think just displaying a warning icon near the top
of the section would be fine instead of wrapping the entire block in an alert
class.

* Original sha: 8be70d4c61
* Authored by Martin Hickey <martin.hickey@ie.ibm.com> on 2016-09-19T09:37:14Z

**Commit 5:**
Move the warning message to near end of the page

Fixes #7661

* Original sha: 14e9bb6c72
* Authored by Martin Hickey <martin.hickey@ie.ibm.com> on 2016-09-20T16:12:45Z

**Commit 6:**
[indexPatterns/field] show the conflict indices as a list, not JSON

* Original sha: 4c96efb6c6
* Authored by spalger <email@spalger.com> on 2016-10-13T03:38:15Z
* Committed by Martin Hickey <martin.hickey@ie.ibm.com> on 2016-10-13T10:12:29Z

**Commit 7:**
[indexPatterns/mapping] extract conflict-describing logic

* Original sha: a71dd2c22b
* Authored by spalger <email@spalger.com> on 2016-10-13T03:40:06Z
* Committed by Martin Hickey <martin.hickey@ie.ibm.com> on 2016-10-13T10:13:46Z
2016-10-17 15:21:10 -04:00
weltenwort
3ff01f2057 Merge pull request #8710 from elastic/jasper/backport/8654/5.x
[backport] PR #8654 to 5.x - Improve discovery test stability and readability
2016-10-17 19:09:45 +02:00
Elastic Jasper
02a5d8a16f Backport PR #8654
---------

**Commit 1:**
Improve readability of some functional tests

Consistently use async/await and bring tests more in line with "Arrange,
Act, Assert".

* Original sha: db775687f2
* Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-11T16:48:37Z

**Commit 2:**
Simplify NoResultsTimefilter link test

This reformulates the test case to a simple sequence of actions and
assertions to improve maintainability.

* Original sha: 88c0b7b75e
* Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-11T17:34:24Z

**Commit 3:**
Replace and remove static sleep calls

Any `sleep()` calls preceding a `verifyChartData()` call seem to be
redundant, because `verifyChartData()` already uses `try()` to avoid
flakyness due to timing.

A few more assertions are now wrapped in `try()` calls to avoid
occasional failures due to the timing of rendering.

* Original sha: d4f717016f
* Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-12T10:12:25Z

**Commit 4:**
Extract expected values into separate variables

to match convention

* Original sha: a5fe202432
* Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-14T08:48:50Z

**Commit 5:**
Take screenshots after assertions

The screenshots are now taken after the corresponding assertions are
made to make sure they actually depict the expected ui state.

* Original sha: 956834430a
* Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-17T11:14:32Z

**Commit 6:**
Use let/const where appropriate

* Original sha: 731fe7924a
* Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-17T16:14:05Z
2016-10-17 12:52:50 -04:00
Tim Sullivan
0259b89592 Merge pull request #8709 from tsullivan/ui-add-link-selector-5.x
[5.x backport] ui: add link selector for cursor pointer
2016-10-17 09:37:36 -07:00
Timothy Sullivan
f98e7050c0 ui: add link selector for cursor pointer 2016-10-17 09:35:19 -07:00
Clinton Gormley
e4c7d41fda Fixed Shield links to point to X-Pack instead 2016-10-17 14:02:07 +02:00
Clinton Gormley
cc1143d5b7 Fixed hard coded doc links 2016-10-17 13:38:51 +02:00
Spencer
ea0f2acb86 Merge pull request #8698 from elastic/jasper/backport/8693/5.x
[backport] PR #8693 to 5.x - [npm] update chromedriver
2016-10-15 00:07:47 -07:00
Elastic Jasper
21bf7b57e8 Backport PR #8693
---------

**Commit 1:**
[npm] update chromedriver

The latest macOS version of Chrome is incompatible with the version of chromedriver we currently depend on, so this updates it.

* Original sha: 29eeed22e2
* Authored by spalger <email@spalger.com> on 2016-10-14T21:03:23Z
2016-10-14 21:23:01 -04:00
Spencer
877c07459a Merge pull request #8668 from elastic/jasper/backport/8538/5.x
[backport] PR #8538 to 5.x - [agg_response/point_series] always assign series labels to points
2016-10-13 16:43:35 -07:00
Spencer
2dc80638b3 Merge pull request #8673 from elastic/jasper/backport/8505/5.x
[backport] PR #8505 to 5.x - [ingest/register_fields_capabilities] prevent calling reply() twice
2016-10-13 16:43:25 -07:00
Stacey Gammon
e080b856db Merge pull request #8675 from elastic/jasper/backport/8642/5.x
[backport] PR #8642 to 5.x
2016-10-13 19:37:38 -04:00
Elastic Jasper
4b54dc6ec8 Backport PR #8642
---------

**Commit 1:**
Fix our request to ES for filtering on scripted fields

Need to use params.value instead of value.

Fixes #8404

Add params prefix in another spot for painless scripted fields

Fix date histogram with scripted fields

Remove format: epoch_millis so the script compiles.  I am not 100%
confident of the side affect from this (it’s used for non-scripted
fields, but I’m not sure where I would put it for scripted fields, or
if it’s needed).  At any rate, it appears that formatting settings for
scripted fields is still being honored, even after removing it from
params.

* Original sha: 7cdb74d6c9
* Authored by Stacey Gammon <gammon@elastic.co> on 2016-10-12T14:54:23Z
2016-10-13 17:43:34 -04:00
Elastic Jasper
f2b363dfec Backport PR #8505
---------

**Commit 1:**
[ingest/register_fields_capabilities] prevent calling reply() twice

* Original sha: e06e659035
* Authored by spalger <email@spalger.com> on 2016-09-30T12:29:46Z
2016-10-13 17:33:37 -04:00
Elastic Jasper
a0fb59f54d Backport PR #8538
---------

**Commit 1:**
[agg_response/point_series] always assign series labels to points

Since forever, the vislib has been compensating for a behavior/bug in the agg_response module where "series" labels were not assigned to points if there wasn't a "series" aggregation or multiple y-axis. To compensate for this, the vislib was assigning the yAxisLabel to the series, which had the same effect, but now that the legend is rendered in it's own tick, followed by the visualization, and that behavior was being executed during the vislib render, the legend has been flashing an empty row for a while (this was worsened by the fact that vislib rendering did not trigger a digest cycle).

These changes remove the workaround code from the vislib, and update the agg_response to always send the y-axis label as the series label when there is no series aggregation. Behavior with multiple-y-axis and multiple series aggs should be preserved.

* Original sha: 7460c0ac2d
* Authored by spalger <email@spalger.com> on 2016-10-04T18:40:41Z

**Commit 2:**
[agg_response/point_series] update tests to reflect changes in 19773a6

* Original sha: f681d6cf86
* Authored by spalger <email@spalger.com> on 2016-10-04T19:22:55Z

**Commit 3:**
[agg_response/point_series] apply PR feedback

* Original sha: a119577af8
* Authored by spalger <email@spalger.com> on 2016-10-04T20:41:29Z

**Commit 4:**
[agg_response/point_series] use no-digest promises in tests

* Original sha: 8d370826c4
* Authored by spalger <email@spalger.com> on 2016-10-04T20:45:02Z
2016-10-13 14:29:02 -07:00
Spencer
04e80c1dc7 Merge pull request #8672 from elastic/jasper/backport/8670/5.x
[backport] PR #8670 to 5.x - [hotfix] force gulp-sourcemaps to 1.7.x
2016-10-13 14:27:48 -07:00
Elastic Jasper
4821255923 Backport PR #8670
---------

**Commit 1:**
[hotfix] force gulp-sourcemaps to 1.7.x https://github.com/floridoo/gulp-sourcemaps/issues/238#issuecomment-253634399

* Original sha: 89a243f605
* Authored by spalger <email@spalger.com> on 2016-10-13T21:09:12Z
2016-10-13 17:27:06 -04:00
Jonathan Budzenski
d2535eaf74 Merge pull request #8655 from elastic/jasper/backport/8651/5.x
[backport] PR #8651 to 5.x - typo fix for advanced-settings.asciidoc
2016-10-13 08:45:53 -05:00
Elastic Jasper
0144a2da7f Backport PR #8651
---------

**Commit 1:**
typo fix for advanced-settings.asciidoc

* Original sha: 45a1e5b8f8
* Authored by fanfan <yu.qifan@zte.com.cn> on 2016-10-13T02:08:25Z
2016-10-13 09:19:57 -04:00
Court Ewing
54cc00bfd6 Merge pull request #8650 from elastic/jasper/backport/8649/5.x
[backport] PR #8649 to 5.x - Fix spelling error of 'reference' in exception message
2016-10-12 21:14:19 -04:00
Elastic Jasper
a670db2123 Backport PR #8649
---------

**Commit 1:**
Fix spelling error of 'reference'

* Original sha: 560f1b1f33
* Authored by Nathan Cheek <nathan.cheek@gtri.gatech.edu> on 2016-10-13T00:12:06Z
2016-10-12 21:06:30 -04:00