Fixes https://github.com/elastic/kibana/issues/181005
Fixes https://github.com/elastic/kibana/issues/181014
This PR adds the group by remote option in the SLO Overview embeddable.
It also fixes a bug with filtering in a grouped view, which would return
no results (both in SLO Overview page and SLO Overview embeddable).
## How to test
**Scenario**: User wants to have an embeddable in their Dashboard with
all SLOs grouped by remote
**Given** user has enabled Remote cluster under SLO Settings in SLO
Overview page
**And** in the Dashboard app they add an SLO Overview Embeddable
**And** they select to group by `Remote` without any extra filtering
**When** they click Save
**Then** They should see all the remote clusters
**And** when they click on the remote cluster they should see the
respective SLOs in the expanded accordion
41162e27-2901-40e1-b704-11c89a6c0fd2
**Scenario**: User wants to have an embeddable in their Dashboard with
all SLOs grouped by a **specific** remote
**Given** user has enabled Remote cluster under SLO Settings in SLO
Overview page
**And** in the Dashboard app they add an SLO Overview Embeddable
**And** they select to group by `Remote`
**And** they select a specific remote cluster from the list of remote
clusters
**When** they click Save
**Then** They should see all the remote clusters
**And** when they click on the remote cluster they should see the
respective SLOs in the expanded accordion
**Before**
b900f8d9-f414-4550-ac65-a1d7bbf9e7b4
**After**
f887342b-9afe-43e9-9795-6c2ae42f413e
**Scenario**: User wants to apply extra filtering to the Grouped
Overview page
**Given** user has grouped by Tags in the SLO Overview page
**And** they want to see only the healthy SLOs
**When** they type `slo.tags: "production"`
**Then** They should see only the production group
**And** when they click on the production group they should see the
respective SLOs in the expanded accordion
bf010cad-42da-476d-9f63-b7a1d6f4295f
## Summary
Introduces a new package for generating OAS from Kibana's routers. This
first iteration includes:
* E2E conversion of Core's `Router` and `CoreVersionedRouter` routes
into a single OAS document (not written to disk or shared anywhere
yet...)
* Support for
[`$ref`](https://swagger.io/docs/specification/using-ref/?sbsearch=%24ref)
by introducing the `meta.id` field `@kbn/config-schema`'s base type.
This is intended to be used only response/request schemas initially.
## TODO
- [x] More unit tests
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
## Summary
Part of https://github.com/elastic/kibana/issues/158861https://github.com/elastic/kibana/pull/180607 added a new log level
selector in Agent Policy settings. However there were some small bugs
with it. This PR addresses all of them:
- Extra dot in copy text
- A broken link was displayed - Made this link optional
- When clicking "Cancel", all the other fields on the page reset back to
their original values but the log level doesn't. The reason is the no
default was set for the select
### Before
### After
### Testing
- Enable `hidden: false`
[here](bc9cd862f0/x-pack/plugins/fleet/common/settings/agent_policy_settings.ts (L133))
- Change the log level and then click "cancel" on the bottom of the
page, it should reset back to the default value ("info" if the policy is
new, the previous saved value if the policy already had this value set)
- No extra dot and link should be visible
## Summary
Closes https://github.com/elastic/kibana/issues/180877
See repro steps in linked issue. Using lowercase dataset name in
template/pipeline names solves the issue with the upgrade.
Will do more testing to make sure the lowercase naming doesn't cause any
issue with agent ingesting.
Verification:
- Tested locally by using a custom log path `/var/tmp/test.log` with a
few lines of logs on a multipass vm.
- Enrolled an agent and verified that the data is going to the
`logs-test` data stream.
- The integration policy is created on Custom Logs version 1.1.2 with
`dataset:Test` and upgraded to 2.3.1.
- The component, index template and ingest pipeline is using a lowercase
`logs-test` prefix.
<img width="1787" alt="image"
src="979d77d3-ba11-4d96-9870-5488c57d7aaf">
<img width="1033" alt="image"
src="3c871462-0498-4b2f-836f-d4b84ac4cf46">
<img width="915" alt="image"
src="e5d34264-650c-4313-b5f6-ff44b0af171d">
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Add bedrock models to FE
- [x] Add playground feature flag to bedrock connectors feature
- [x] Support bedrock models on server side using ActionClientLlm
<img width="343" alt="image"
src="207101ca-d6b0-448a-b3c4-d894195ccb1c">
---------
Co-authored-by: Joseph McElroy <joseph.mcelroy@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Closes: https://github.com/elastic/security-team/issues/8577
### Description
The [axe browser plugin](https://deque.com/axe) is reporting the Alert
landing data grid checkboxes do not have accessible labels. Screenshot
attached below.
### Steps to recreate
1. Open the [Alerts landing
page](https://kibana.endpoint.elastic.dev/app/security/alerts?sourcerer=(default:(id:security-solution-default,selectedPatterns:!(%27auditbeat-*%27,%27filebeat-*%27,%27logs-*%27,%27packetbeat-*%27,%27winlogbeat-*%27)))&filters=!((%27$state%27:(store:appState),meta:(alias:!n,disabled:!f,key:kibana.alert.rule.execution.uuid,negate:!f,params:(query:%2750cd1424-87b7-42ae-ab3e-b4b111c0504e%27),type:phrase),query:(match_phrase:(kibana.alert.rule.execution.uuid:%2750cd1424-87b7-42ae-ab3e-b4b111c0504e%27))))&timerange=(global:(linkTo:!(),timerange:(from:%272024-02-05T18:05:33.666Z%27,kind:absolute,to:%272024-02-07T18:05:33.666Z%27)),timeline:(linkTo:!(),timerange:(from:%272024-02-05T17:39:36.717Z%27,kind:absolute,to:%272024-02-06T17:39:36.717Z%27)))&timeline=(activeTab:query,graphEventId:%27%27,isOpen:!f)&pageFilters=!((exclude:!f,existsSelected:!f,fieldName:kibana.alert.workflow_status,selectedOptions:!(),title:Status),(exclude:!f,existsSelected:!f,fieldName:kibana.alert.severity,selectedOptions:!(),title:Severity),(exclude:!f,existsSelected:!f,fieldName:user.name,selectedOptions:!(),title:User),(exclude:!f,existsSelected:!f,fieldName:host.name,selectedOptions:!(),title:Host)))
2. Run the axe scan from Chrome or Firefox dev tools to verify the data
grid checkboxes need accessible labels
### What was done?:
1. `aria-label` attribute was added for `BulkActionsRowCellComponent`
### Screen:
<img width="846" alt="image"
src="d67d3189-7dea-4ab0-9e3e-caaa2c7d00f7">
## Summary
fix https://github.com/elastic/kibana/issues/179524
I think we got this regression when we moved reporting code around
packages.
I assume the `error instanceof
errors.InsufficientMemoryAvailableOnCloudError` check doesn't work
because the error was thrown in screenshoting plugin using its instance
of `errors.InsufficientMemoryAvailableOnCloudError` but the check
happens in reporting plugins using a different instance of
`errors.InsufficientMemoryAvailableOnCloudError`. The fix is to check
the error type by `name`, interesting that for other type of errors we
already had `name` check in place
Closes#176994
## Summary
This PR adds Hosts and Inventory to the global search (now not only in
serverless)
Fixes#178760
## Summary
- `useQuery` expects `fetchActionTypes` to return a promise so I changed
an instance of `mockImplementation` in the tests to `mockRejectedValue`.
- Increased the `waitForNextUpdate` timeout value.
Fixes#176336
## Summary
The only thing I could find in the test was a bunch of unnecessary DOM
searches. This is one of the most expensive operations in tests so I:
1. Converted the 3 redundant
`findByTestId('options-filter-popover-button-severity')` into just 1.
2. Did a single `findAllByRole('option')` instead of a search for every
single value + a search for all to guarantee length was 4.
Locally the test duration was reduced from 300ms to 150+-. Let's see how
it behaves in the pipeline.
Relates to https://github.com/elastic/kibana/issues/179638.
## 📝 Summary
This PR is all about decoupling `integrations` from `DataStreamStats`
request.
This change is needed in order to render dataset quality table from only
`DegradedDocsStats` or `DataStreamStats`, this will allow us to show the
users the information as soon as it arrives, also will help us to
introduce soonish states according to user privileges.
### Changes
- New internal endpoint `GET /internal/dataset_quality/integrations`
that will return all the installed integrations that are of a specific
type, e.g. `logs`.
- Generating datasets when integrations request has finished, so we
render the integration information correctly and show the information
available: dataStreamStats and/or degradedDocs.
### App statechart
<img width="949" alt="image"
src="3548d3e8-f99c-4d79-86af-4926dfec7b5e">
### Demos
#### dataStreamStats taking longer to resolve
c1127ec2-2cfe-4796-a331-47a3ef718e98
#### degradedDocs taking longer to resolve
b6f9954f-8e2b-445f-89a5-b6d213abe4b1
#### dataStreamStats and degradedDocs loading
e7987657-41cd-4cfc-b24e-6ad47aed0df1
#### Integration request failed but we still show information related to
datasets
965558f3-4660-47e9-a7a1-068491e08a8a
## Summary
`max` and `min` accept date fields. This updates the validator and
autocomplete to reflect this!
<img width="500" alt="Screenshot 2024-04-16 at 8 53 18 AM"
src="1c363b1a-c390-4eda-a4fc-615bea66c0a2">
_`min` gets date fields_
<img width="500" alt="Screenshot 2024-04-16 at 8 53 08 AM"
src="4ed09a71-d84c-4a2f-a8e0-d2fcc362ee94">
_`avg` does not_
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
## Summary
This PR refactors https://github.com/elastic/kibana/pull/179206 to have
each export type be registered in Reporting and then passed into the
share plugin.
This PR is focused on the redesign in terms of the export modals. Test
refactoring will be done in a separate PR.
Partially closes https://github.com/elastic/kibana-team/issues/753
- [x] Need to refactor this PR to include @eokoneyo's general modal
component
- [x] Lens needs to have Export with all three report type options - to
avoid circular dependencies move the Lens CSV stuff into the reporting
plugin vs having it in Lens
- [x] Canvas should not be affected by these changes (so the old
share/reporting code has to stay for canvas)
https://github.com/elastic/kibana/issues/151523 to keep in mind for the
redesign
Failed tests will be covered in this PR
https://github.com/elastic/kibana/pull/180406
### TO TEST
Mark `share.new_version.enabled: true` in your kibana.dev.yml
### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
---------
Co-authored-by: Eyo Okon Eyo <eyo.eyo@elastic.co>
Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
## Summary
This is needed where users want to generate links to synthetics monitors
using uptime alerts !!
### Example usage
<img width="625" alt="image"
src="4f2f7833-9313-4c3a-8ea0-a383cb2ec857">
<img width="956" alt="image"
src="10541a9c-987b-427c-a55e-4e0ba01891cf">
closes https://github.com/elastic/kibana/issues/178719
A new ES API has been created to support linking APM from the Profiling
UI. It's called `topN/functions`. The new API allows grouping fields. So
we first fetch functions grouping by `service.name` and when the user
opens the APM Transactions we make another request grouping by
`transaction.name`.
A new Advanced setting was created to toggle the old API on (fetch
functions from Stacktraces API): It's turned off by default.
<img width="1235" alt="Screenshot 2024-04-12 at 10 39 36"
src="ee6e7731-2f44-43ca-9793-23ba87e22e6e">
When there are services on the selected function:
*If we cannot find the transaction, we show `N/A`.
<img width="933" alt="Screenshot 2024-04-12 at 10 16 34"
src="2c5dbf60-3a47-4f4c-a46d-8a0984e0e482">
When there are **no** services on the selected function:
*hide the APM transactions section
<img width="921" alt="Screenshot 2024-04-12 at 10 59 14"
src="3fc4c5b1-da62-47c8-97a8-8bcbd1ae1b75">
--
Performance boost:
The new API is faster than the Stacktraces API, especially because
there's no logic on the Kibana side.
Stacktraces API:
<img width="1210" alt="Screenshot 2024-04-12 at 10 50 26"
src="158d73d1-ed91-4652-97c1-c7c3328d5e3d">
TopN/Functions API:
<img width="1195" alt="Screenshot 2024-04-12 at 10 51 20"
src="2de4ef46-eb8a-4557-b7b8-a1c2fed6fd8a">
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Adds the Breakdown field to Degraded Docs Visualization.
The PR exposes the `BreakdownFieldSelector` from
**@kbn/unified-histogram-plugin** as a similar visualization behaviors
and actions are needed on the Dataset Quality flyout as with Logs
Explorer.
<img width="1242" alt="Screenshot 2024-04-12 at 04 00 06"
src="0e34397a-ac56-4a2b-8483-94c96dcbf3c2">
## Summary
- Renames `GlobalAlertsPage` to `StackAlertsPage` to better account for
the change in scope
- Renames the `triggerActionsUi.globalAlertsPage` flag to
`triggerActionsUi.stackAlertsPage`
- Toggles the flag on by default
- Updates the tech preview badge to match the other badges used across
triggers_actions_ui
- Fixes the feature cell rendering logic not displaying Observability
alerts correctly
- Other small fixes and improvements
## To verify
1. Navigate to the `Stack management > Alerts` page (the page should now
be visible without a the feature flag turned on manually)
2. Check that the tech preview badge appears correctly and shows the
tooltip on hover
3. Check that Observability alerts show an `Observability` badge in the
`Feature` column
## Bugs Fixed
1. The OpenAI `invokeAI` method did not properly handle `signal`
2. Bedrock did not have a `signal` implementation at all 😳
## Summary
In my [LangChain streaming
PR](https://github.com/elastic/kibana/pull/174126), I poorly implemented
a fix to stop the stream on the server when "Stop generating..." was hit
on the client. I did this by piping through an `AbortSignal` to
`invokeStream`/`invokeAsyncIterator` subactions. However, in the
`invokeAI` subaction I did not properly remove `signal` before
`JSON.strinigfy`ing the body, so the below error was happening in the
security non-streaming implementation. Additionally, for Bedrock I
somehow only implemented `signal` in part of the type and nothing else,
so token tracking would be off when Stop generating button is hit 🤦
<img width="1376" alt="Screenshot 2024-04-15 at 2 00 38 PM"
src="e57241d9-9fd2-4dd3-bb3a-72a7c61a3d4b">
## To test
1. Turn off streaming in the Security AI Assistant and select an OpenAI
connector (LangChain off)
3. Send a message
4. Ensure expected results (prior the above error would occur)
The test of the Bedrock connector will be harder to confirm. Where the
issue would show up would be subtle, in the token counter. Before I
implemented the signal in the Bedrock connector, if you ask Bedrock to
repeat a word 100 times with streaming enabled, and then hit "Stop
generating..." after 10 words, you would see a token count for
`completion_tokens` be equivalent to ~100 tokens as the full response
would have "streamed" on the server. After this bug fix, if you hit
"Stop generating..." after 10 words, you will see a token count for
`completion_tokens` be equivalent to ~15 tokens as it takes a second for
the `abort()` to reach the server. To be clear, this bug would not have
shown in persistent storage because we call abort in
`handleStreamStorage` ASAP instead of relying on axios to complete its
abort.
## Summary
Exclude tiers function wasn't working for alerting and other server side
data view usage. This PR moves the tier exclusion code to a more central
location so it will apply in ALL circumstances, not just REST API
requests for fields.
There are three places that call the IndexPatternsFetcher - the
fields_for_wildcard API, the fields API, and the IndexPatternsApiServer
for server side field loading.
Oh, `x-pack/plugins/alerting/server/routes/suggestions/fields_rules.ts`
calls IndexPatternFetcher too. And some rules, which don't need this
functionality. IndexPatternsFetcher is used in more places than I knew /
intended.
Closes https://github.com/elastic/kibana/issues/180675
## Summary
Changes done in SentinelOne connector in support of Security Solution
`get-file` response action (forthcoming):
- Added `fetchAgentFiles()` sub-action
- Added `downloadAgentFile()` sub-action
- Added `getActivities()` sub-action
- Improved error messages for SentinelOne API failures
- Added `logger.debug()` to Sub-Actions connector `validateResponse()`
to output data that failed validation
## Summary
Fixes a bug with OpenAI (not azure) connectors when used with
`invokeAsyncIterator`:
```
ActionsClientChatOpenAI: an error occurred while running the action - Unexpected API Error: - 404 Invalid URL (POST /v1/chat/completions/chat/completions)
```
Our current default url for OpenAI connectors is
`https://api.openai.com/v1/chat/completions`
When using the `invokeAsyncIterator` subaction, we use the OpenAI node
package. This takes the url as an argument to instatiate. It wants the
URL of OpenAI, not the completions endpoint which is our default.
Looking back, I wish we had made the default url
`https://api.openai.com/v1`. However, because we want to support
existing connectors I think we should keep this the default and remove
the endpoint from the url when it is passed to the OpenAI node package.
### To test
Send a message in Security Assistant with an OpenAI (not azure)
connector with streaming enabled. Observe a successful response.
### Note to docs team
@elastic/security-docs We should call this out. If a user has an open
source OpenAI connector with a chat completions endpoint that does not
have the same structure as OpenAI's ending in `/chat/completions`, their
full endpoint url will be used with LangChain OpenAI Streaming
implementations. For example, if a user had a url like
`https://mycustomllm.com/execute/completions` and tries to use the the
Security Assistant with Knowledge Base on and Streaming on, they may get
this error:
```
ActionsClientChatOpenAI: an error occurred while running the action - Unexpected API Error: - 404 Invalid URL (POST /execute/completions/chat/completions)
```
We should instruct them to follow the same route structure as OpenAI.
Their endpoint needs to end in `/chat/completions`
## Summary
Moves Security's alerts filter controls bar implementation to the
`@kbn/alerts-ui-shared` package for re-use in the Stack alerts (unified)
page and Observability solution (separate PR).
<img width="1339" alt="image"
src="986e984a-0290-4980-859b-9d6e02ef335f">
## To verify
1. Enable the Stack alerts page feature flag:
```yaml
# config/kibana.dev.yml
xpack.trigger_actions_ui.enableExperimental:
- globalAlertsPage
```
2. Create some Stack/O11y rules that fire some alerts
3. Navigate to `Management > Stack management > Alerts`, you should see
the new controls below the KQL bar.
4. Check that the filters apply correctly and reflect on the table
results
5. Check that the filter controls can be customized (`••• > Edit
controls`, add/remove controls, save)
6. Check that the customized configuration persists across reloads
7. Check that the filter controls can be temporarily overridden through
the URL param `filterControls`
8. Check that when the filters are overridden through the URL, a notice
is shown to the user with CTAs to discard/save the temporary filter
configuration
---
1. Navigate to `Security > Alerts > Manage rules`
2. Create one or more security rule that fire alerts
3. Go back to the security alerts page
4. Repeat steps 4-8
Closes#176711
---------
Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jatin Kathuria <jtn.kathuria@gmail.com>
This adds an API call to the contextual insights component which should
improve the relevance of the responses by providing more context to the
LLM.
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
## Summary
This pr makes use of a new prop (and some generic memoization fixes) in
2 eui prs merged recently (https://github.com/elastic/eui/pull/7556 and
https://github.com/elastic/eui/pull/7374) to improve the performance of
the alerts table. Mainly, the cellContext prop is now available to
consumers of the triggersActionsUi alerts table to pass in custom props
in a way that allows the renderCellValue/rowCellRender functions of the
various EuiDataGrid prop apis to remain referentially stable across
re-renders. There are also some various changes to various hooks and
props found throughout plugins that use the table to improve
performance. There should be no change in functionality, just a moderate
to substantial reduction in time the app spends rendering the alerts
table in various scenarios. Below will be some react dev tools
performance profiles, main compared to this branch, with the exact same
set of generated data.
Main, switching from 10-100 rows:
This branch 10-100 rows:
Pretty modest gain here, 1 render is slower than any others on main, but
overall less time spent rendering by about a second.
Main, opening the cell popover on 2 cells
This branch, opening cellpopover
Again nothing crazy here, modest improvement.
Main opening timeline and hitting refresh
This branch, opening timeline and hitting refresh
This is the case that brought this about in the first place, as security
solution shares a lot of code between tables, the alerts table
recreating all cells on every render was destroying performance of the
timeline rendering in a flyout/modal while users were on alerts page or
the rule detail page, which is probably the most common use case. 93ms
in this branch vs 2500+ ms in main. This type of performance hit happens
when almost any action is taken in timeline.
Main, selecting 3 alerts 1 at a time
This branch selecting 3 alerts 1 at a time
Pretty substantial improvement here as well, ~2000ms vs 67ms.
Apologies if some of the gifs are cut off, please try the branch vs main
on your own! This was done on a local kibana in dev mode, so things like
emotion are eating up more cpu than they would for a user, but there
still should be improvement, and I can't think of any circumstance where
things will be worse. Also this branch was a little longer lived than I
would have liked, so if you are reviewing and changed something around
these files recently please double check I didn't miss anything.
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
## Summary
- [x] Adds updated warning messaging for trusted apps entries that use
wildcards `*?` with the "IS" operator
- [x] Three different warnings: callout, individual entry item warnings
and a final confirmation modal when the user tries to add an event
filter with ineffective IS / wildcard combination entry.
- [x] Unit tests
- [x] Fixes bug in endpoint exceptions where there is a missing tooltip
icon for the wildcard performance warning
# Screenshots
Bug Fix
## Summary
Adds a bunch of descriptive tooltips to the stats.
<img width="324" alt="Screenshot 2024-04-16 at 15 02 57"
src="c0df028f-ad1d-45c3-b16e-abaa496b55ad">
<img width="283" alt="Screenshot 2024-04-16 at 15 03 11"
src="8569e289-4a21-4df2-9f5c-7d75205a03f2">
<img width="281" alt="Screenshot 2024-04-16 at 15 03 13"
src="f17b6023-0468-46c7-b5b0-c7c62af5c353">
### Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
### Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to
identify risks that should be tested prior to the change/feature
release.
When forming the risk matrix, consider some of the following examples
and how they may potentially impact the change:
| Risk | Probability | Severity | Mitigation/Notes |
|---------------------------|-------------|----------|-------------------------|
| Multiple Spaces—unexpected behavior in non-default Kibana Space.
| Low | High | Integration tests will verify that all features are still
supported in non-default Kibana Space and when user switches between
spaces. |
| Multiple nodes—Elasticsearch polling might have race conditions
when multiple Kibana nodes are polling for the same tasks. | High | Low
| Tasks are idempotent, so executing them multiple times will not result
in logical error, but will degrade performance. To test for this case we
add plenty of unit tests around this logic and document manual testing
procedure. |
| Code should gracefully handle cases when feature X or plugin Y are
disabled. | Medium | High | Unit tests will verify that any feature flag
or plugin combination still results in our service operational. |
| [See more potential risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) |
### For maintainers
- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
---------
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
