Dominique Clarke
b1d2211f9f
[Synthetics] Monitor add/edit - do not focus error via react hook form ( #144756 )
...
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Resolves https://github.com/elastic/kibana/issues/144363
2022-11-10 13:41:11 +01:00
Ashokaditya
8a34465b29
[Security Solution][Endpoint][RBAC V1] Show Host Isolation Page only to superusers for RBAC v1 ( #144711 )
...
## Summary
- [x] Updates the logic for showing host isolation pages for RBAC v1.
- [x] should allow `superusers` to delete an artifact if exists even
when the license is below `platinum`
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
2022-11-10 04:24:45 -07:00
Dominique Clarke
42fdcb6981
[Synthetics] adjust synthetics preview toggle to indicate technical preview status ( #144934 )
...
Resolves https://github.com/elastic/kibana/issues/144914
2022-11-10 11:23:49 +01:00
Dominique Clarke
0cae7ed66e
[Synthetics] filter by location for monitor details visualizations ( #144873 )
...
Resolves https://github.com/elastic/kibana/issues/144857
2022-11-10 11:13:54 +01:00
Jean-Louis Leysens
b55fd23c88
[Files] Wait for all shards to be active ( #144892 )
...
## Summary
There is a potential race-condition between creating files for the first
time and shards being ready on the index that stores them in ES.
This PR adds a way for all subsequent calls to uploading files to only
proceed once the destination index is created and all shards are ready.
- [x] Added functional test
2022-11-10 10:46:51 +01:00
Antonio
f1d5f4488d
[Cases] Wrap the all cases list tags column ( #144787 )
...
## Summary
This PR aims to stop the truncating behavior from the Tags column in the
all-cases list.
* An ellipsis shows up if there are too many tags
* The height is limited to three rows
* The tooltip behavior remains
* Fixed the tags column width
### Screenshots
<details><summary>Before:</summary>
<img width="1408" alt="Screenshot 2022-11-08 at 10 48 34"
src="https://user-images.githubusercontent.com/1533137/200531920-03442218-7151-471b-9ff7-66f31acf1f56.png ">
</details>
<details><summary>After</summary>
<img width="1425" alt="Screenshot 2022-11-08 at 10 47 51"
src="https://user-images.githubusercontent.com/1533137/200531952-f2c9be6e-0a7d-41e2-bd8c-03c6f36635d0.png ">
</details>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-11-10 10:45:43 +01:00
Maja Grubic
f02cf40fdc
[Management] Add share as a required dependency ( #144381 )
...
## Summary
This PR adds `share` as a required plugin of `management` plugin.
I created a new plugin and was trying to add "management" as a
dependency. This was throwing an error when starting Kibana:
```
TypeError: Cannot read properties of undefined (reading 'url')
at ManagementPlugin.setup (plugin.ts:42:1)
```
caused by:
https://github.com/elastic/kibana/blob/main/src/plugins/management/public/plugin.ts#L78
It looks like `share` was declared as an optional plugin but it didn't
handle a scenario when it was not provided.
### Checklist
Delete any items that are not applicable to this PR.
~- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )~
~- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials~
~- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios~
~- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard
accessibility](https://webaim.org/techniques/keyboard/ ))~
~- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))~
~- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )~
~- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))~
~- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers )~
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-11-10 10:36:45 +01:00
Robert Oskamp
cf281d61ca
[ML] Functional tests - stabilize and re-enable test suites ( #144784 )
...
This PR stabilizes and re-enables a few ML functional test suites.
2022-11-10 10:35:40 +01:00
Or Ouziel
878f3f1b3f
[Cloud Posture] update benchmark menu item description ( #144813 )
2022-11-10 11:09:35 +02:00
Joe Reuter
2dce056bd8
[Lens] Change semantic elements ( #144828 )
...
Fixes https://github.com/elastic/kibana/issues/143547
To make sure the correct semantic elements are used, you can pass the
`component` prop to the page template components. As the eui components
`EuiPageTemplate`, `EuiPageTemplate.Section` and so bring styling with
them there's not much value in trying to put them into the places of
manual `section`s used in Lens today because we would end up overruling
all of these default styles anyway as Lens is pretty special in terms of
page layout to make best use of the existing screen real estate.
Because of this this PR is simply turning the `EuiPageTemplate` into a
div and putting the main role to the top level of the Lens app.
The way how to do this is a bit funky right now, but that's an EUI bug
that will be fixed upstream: https://github.com/elastic/eui/issues/6351
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
2022-11-10 09:51:05 +01:00
Julia Bardi
c7cdd00036
[Fleet] Request diagnostics ( #142369 )
...
## Summary
Closes https://github.com/elastic/kibana/issues/141074
### Request diagnostics action
Added new action for single agent (Agent details page and Agent list row
actions) to request diagnostics.
When clicking on the action, an API request is made that creates a
`REQUEST_DIAGNOSTICS` type action in `.fleet-actions` index.
### Diagnostics uploads display
When the action is submitted, the user is navigated to the new `Agent
Details / Diagnostics` tab, which shows the list of pending and
completed diagnostics file uploads. The information is coming from the
`/action_status` (for action status) as well as the `/uploads` endpoint
(for file name and path)
By clicking on a diagnostics link, the file should be downloaded in zip.
<img width="1060" alt="image"
src="https://user-images.githubusercontent.com/90178898/193816708-803c2a22-d421-4af2-9a78-785cdee81136.png ">
Failed uploads display:
<img width="638" alt="image"
src="https://user-images.githubusercontent.com/90178898/194058366-d4874339-9fd1-419e-99e5-f592a6b3bf6d.png ">
Expired status was not specified in the design separately, it will be
shown like the failed status (with warning icon).
### Mock data (blocker)
Currently returning mock data in the `/uploads` API, because of a
blocker in Kibana File Service, see
[here](https://github.com/elastic/kibana/issues/141074#issuecomment-1267078759 ).
### Bulk action
Added bulk action too:
<img width="1759" alt="image"
src="https://user-images.githubusercontent.com/90178898/194026861-bf0d5956-de2d-4d2b-895a-c35cf5252a5a.png ">
Shows up in agent activity:
<img width="594" alt="image"
src="https://user-images.githubusercontent.com/90178898/194026960-356a5b40-1203-4182-ad7b-89b1432bf0f6.png ">
The Fleet Server / Agent changes are not there yet, though FS delivers
the action, and Agents ack it (looks like default behavior for unkown
actions as well)
### Confirmation modal
Added a confirmation modal when clicking on action button everywhere,
except for the `Request diagnostics` button on the Diagnostics page.
Open question:
- Do we want to display the confirmation window on the Diagnostics page
button too?
<img width="673" alt="image"
src="https://user-images.githubusercontent.com/90178898/194065175-715b158e-0628-4bd9-86db-920c1ec9825e.png ">
### Download
Generated file path to download in this format:
`/api/fleet/agents/files/{fileId}/{fileName}`
Decided not to try to use `files` plugin's API because it doesn't have
the Fleet authorization around it.
Screen recording demonstrating the download of an agent diagnostics zip
file, that I uploaded using the Fleet Server upload API (using [Dan's
pr](https://github.com/elastic/fleet-server/pull/1902 ) locally)
https://user-images.githubusercontent.com/90178898/194287842-c7f09c9e-5310-460f-9cae-6fc7fa7750de.mov
### Notification
Added toast message to show up when a diagnostics becomes ready, when we
are on the Diagnostics tab.
https://user-images.githubusercontent.com/90178898/194318170-e7ec66db-8bf8-4535-b07e-682397c2920c.mov
### Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-11-10 09:24:22 +01:00
Uladzislau Lasitsa
545ebb012d
[Lens] Expose helpers to capture meta information from Lens state ( #144546 )
...
## Summary
Closes : #131710
In order to add complimentary features to Lens embeddables via actions,
it's important to be able to capture the relevant information from the
state which is currently loaded.
E.g. https://github.com/elastic/kibana/pull/129762 is pulling out the
used field names from the Lens state. While the state interface is
considered a public interface (as it's also used to configure Lens
embeddables), it would be beneficial to provide use case specific
helpers to extract this information to make this logic easier to
maintain.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-11-10 10:05:41 +02:00
Walter Rafelsberger
1d511a439d
[ML] Explain Log Rate Spikes: Allow to continue failed stream. ( #143301 )
...
The analysis can be long running and in cases can time out depending on
server/proxy settings. This update allows a user to try to continue the
analysis if it failed half way through.
2022-11-10 09:03:44 +01:00
Gergő Ábrahám
3a24c1f8a6
[Security Solution] Show correct Privileges Required page for unauthorized paths ( #144821 )
...
## Summary
The goal is to show a _Privileges required_ or _Superuser required_
message to users if they want to access a page in Security Management
they don't have access for, based on feature flags.
`<PrivilegedRouter>` decides which message to show:
- current version (no feature flags): _superuser required_ for all pages
- v1 (`endpointRbacV1Enabled`):
- _privileges required_ only for _Response actions history_
- _superuser required_ for other pages
- v2 (`endpointRbacEnabled`): _privileges required_ for all pages
To test it:
- change the feature flags,
- create a non-superuser user, with different Kibana privileges
- and check the urls for Security Management pages, e.g.
http://localhost:5601/app/security/administration/response_actions_history
Without feature flags:
<img width="998" alt="image"
src="https://user-images.githubusercontent.com/39014407/200780212-e16246a0-76d4-4c8a-a9b9-6b2b4466e7b8.png ">
v1/v2 for Response actions history:
<img width="1006" alt="image"
src="https://user-images.githubusercontent.com/39014407/200780408-c80ca58b-9d06-47cd-beb9-c764ef5f1380.png ">
### Dev note
A refactor PR for reusing the new `<NoPrivilegesPage>` component in 3
other places inside security solution plugin is ~coming soon.~ here:
https://github.com/elastic/kibana/pull/144886
### Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html )
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
2022-11-10 08:53:55 +01:00
Kibana Machine
76402eda9e
[api-docs] 2022-11-10 Daily api_docs build ( #144959 )
...
Generated by
https://buildkite.com/elastic/kibana-api-docs-daily/builds/152
2022-11-10 00:44:08 -05:00
Steph Milovic
b721fdcf42
[Security solution] Guided onboarding, alerts & cases design updates ( #144249 )
2022-11-09 14:13:10 -07:00
Wafaa Nasr
47f38bc3df
[Security Solution] [Exceptions] Add ListExceptionItem Component and its components with implementing the logic + restructuring exceptions under security ( #144622 )
...
## Summary
**Shared List Collapsed**
<img width="1226" alt="image"
src="https://user-images.githubusercontent.com/12671903/200085472-ba638911-af4e-4e6d-85a3-7692b174fad5.png ">
**One Shared list expanded**
<img width="1442" alt="image"
src="https://user-images.githubusercontent.com/12671903/200085548-2b6ef100-8587-47c5-b08d-9727bd2c25c0.png ">
**Shared List with no Exceptions**
<img width="1180" alt="image"
src="https://user-images.githubusercontent.com/12671903/200531307-4b3d0d02-a7c7-4232-98cc-7d0f1b4e48c5.png ">
**Add Exceptions from Shared List Card**
<img width="1461" alt="image"
src="https://user-images.githubusercontent.com/12671903/200531393-833173ea-c5a8-4ab3-b947-257154f6aa90.png ">
**Exit Exception from Shared List Card**
<img width="1463" alt="image"
src="https://user-images.githubusercontent.com/12671903/200531750-e888a0fa-d95c-4994-8ead-f119611fc561.png ">
**Delete Endpoint is disabled**
<img width="1186" alt="image"
src="https://user-images.githubusercontent.com/12671903/200531542-773348c2-c2e2-4062-94e1-12340756ebc3.png ">
1. **New components**
a. `list_details_link_anchor` => This component should be removed and
moved to @kbn/securitysolution-exception-list-components once all the
building components get moved
b. `exceptions_utility` => This component should be removed and moved to
@kbn/securitysolution-exception-list-components once all the building
components get moved
c. `list_exception_items ` a wrapper over the ExceptionItem from the
`@kbn/securitysolution-exception-list-components` added to pass the
missing above components, should be removed soon once everything gets
moved to the kbn package
2. **New Hooks**
a. `use_list_exception_items` => holds all the Exceptions' items' logic
b. `use_exceptions_list.card` => hold all the exception card logic
4. Apply Designs to the Shared Lists
5. **Restructure folders under the
`x-pack=>security_solution=>exceptions`**
a. components
b. hooks
c. pages
d. translations
e. utils
6. Added excluded files in `jest.config`
7. Renamed the `shared_list` components in `routes`
### Checklist
Delete any items that are not applicable to this PR.
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-11-09 20:59:50 +01:00
Tim Rühsen
f7758e0ada
[Profiling] Improve the differential flamegraph tooltip ( #144895 )
...
Improve the root tooltip for the differential flamegraph:
- remove the superfluous CPU usages (it's always 100% inclusive and 0%
exclusive)
- add the change rate of the samples as colored text
**Before**
**After**
Improve the non-root tooltips for the differential flamegraph:
- remove the 'no change' label if there is no change
- add the change rate of the samples as colored text
**Before**
**After**
Fixes https://github.com/elastic/prodfiler/issues/2714
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joseph Crail <joseph.crail@elastic.co>
2022-11-09 11:58:35 -08:00
renovate[bot]
ec3e66e213
Update dependency react-hook-form to ^7.39.0 (main) ( #144874 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
2022-11-09 20:46:56 +01:00
Thomas Dullien
0a5050bd37
[Profiling] Small improvements to the differential function view ( #144824 )
...
Improved the visualization of data in profiling by showing more details
and using more nicely formatted numbers.
Fixes https://github.com/elastic/prodfiler/issues/2772
Co-authored-by: Tim Rühsen <tim.ruhsen@elastic.co>
2022-11-09 11:27:36 -07:00
Kaarina Tungseth
64c3c63e21
[Lens] Updates the UI copy for Random sampling ( #144265 )
...
## Summary
Updates the Random sampling copy.
Original PR: #143929
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-11-09 12:00:25 -06:00
Felix Stürmer
c88a680c60
[Logs UI] Use the Unified Search Bar for date range selection ( #144351 )
...
This enables the date-picker of the unified search bar introduced into the Logs UI in #143222 and simultaneously removes the custom date picker.
closes https://github.com/elastic/kibana/issues/142767
2022-11-09 18:49:32 +01:00
Thomas Neirynck
59f2ff5c2d
Add October newsletter link ( #144860 )
...
Adds link to October newsletter
2022-11-09 12:22:33 -05:00
Dominique Clarke
17625d5780
[Synthetics] Overview - fix disabled status count ( #144903 )
...
## Summary
Fixes a typo with disabled status count.
2022-11-09 12:20:49 -05:00
Rashmi Kulkarni
49986dab34
testing a flaky functional test ( chained input control) ( #144770 )
...
trying to fix: https://github.com/elastic/kibana/issues/96997
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-11-09 09:02:16 -08:00
Kaarina Tungseth
1a660f027f
[Lens] Updates Series color tooltip ( #144846 )
...
## Summary
Updates the Series color tooltip to:
`You are unable to apply custom colors to individual series when the
layer includes a "Break down by" field.`
2022-11-09 10:59:41 -06:00
Miriam
df43ad4e1e
[APM] Skip test after change in fleet url params ( #144905 )
...
Skipped failing test after change in fleep url params
https://github.com/elastic/kibana/pull/144343
Test will be fixed during test plan
https://github.com/elastic/kibana/issues/144907
2022-11-09 09:57:20 -07:00
Tim Sullivan
192068d9bd
[Reporting] Unskip screenshotting timeouts test ( #144580 )
...
## Summary
Closes #135309
See:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1528
2022-11-09 09:53:59 -07:00
Mark Hopkin
d20bdb56d7
[Fleet] Bugfix: always use posix paths for zip files ( #144899 )
...
## Summary
Always use posix style paths when generating paths for the package
archives.
2022-11-09 16:53:08 +00:00
Nathan Reese
49f3c24428
[Maps] enable allowJs ( #144742 )
...
Fixes https://github.com/elastic/kibana/issues/144287
PR resolves TS errors when setting allowJs to true in Maps plugin
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-11-09 09:50:46 -07:00
James Gowdy
bfa1a7f20b
[ML] Adding cloud trial end date to ml info ( #144793 )
...
Adds a `isCloudTrial` flag to ML's `/api/ml/info` endpoint.
If `xpack.cloud.trial_end_date` is set in the kibana config and it is
greater than the current time, we can assume that we're currently in a
could trial.
If `xpack.cloud.trial_end_date` is not set, `isCloudTrial` is not added
to the endpoint response. This is the same behaviour as the `cloudId`
property.
Adds a `isCloudTrial()` function to our server info util functions which
can be used in conjunction with our `isCloud()` function.
To test, these cloud settings can be added to the kibana config:
```
xpack.cloud.id: 'cloud_message_test:ZXUtd2VzdC0yLmF3cy5jbG91ZC5lcy5pbyQ4NWQ2NjZmMzM1MGM0NjllOGMzMjQyZDc2YTdmNDU5YyQxNmI1ZDM2ZGE1Mzk0YjlkYjIyZWJlNDk1OWY1OGQzMg=='
xpack.cloud.trial_end_date: '2022-11-20T09:39:52.554Z'
```
2022-11-09 16:40:23 +00:00
Tiago Costa
7fbf260cc9
chore(NA): enable missing ts performant flags ( #144872 )
...
This PR enables `incremental` and `skipDefaultLibCheck` across the board
on our TS setup as recommended on the official TS performance wiki.
2022-11-09 09:36:34 -07:00
Aleh Zasypkin
1213fa0bcd
Upgrade loader-utils dependency (1.1.3 → 2.0.3). ( #144879 )
...
## Summary
Upgrade `loader-utils` dependency (`1.1.3` → `2.0.3`).
Change log (`loader-utils`):
https://github.com/webpack/loader-utils/blob/master/CHANGELOG.md#200-2020-03-17
__Note to reviewers:__ Change log isn't really helpful, and not all
versions are covered. The only important part is the list of the
breaking changes in `2.0.0`:
* 🟢 minimum required Node.js version is 8.9.0 (sounds good)
* 🟡 the `getOptions` method returns empty object on empty
query (would be great if code owners validate if it's okay, it looks
like theme_loader is the only place where _we_ directly use this method)
* 🟡 Use md4 by default (would be great if code owners
validate if it's okay)
cc @elastic/kibana-security
2022-11-09 17:25:15 +01:00
Dmitry Tomashevich
a9162f7481
[Discover] Enable esQuery alert for adhoc data views ( #140885 )
...
## Summary
Closes #142514 #142389
This PR does the following:
- Enables to create `esQuery` (in KQL or Lucene mode) using adhoc data
views from discover and management pages
- Adds `explore matching indices` button to data view picker in alert
flyout
- Adding adhoc data views from alert flyout should propage them to a
main discover picker
### Checklist
- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing ), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md )
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html )
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/ ))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/ ),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US ))
- [x] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker )
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server ))
Co-authored-by: Davis McPhee <davis.mcphee@elastic.co>
2022-11-09 18:55:34 +03:00
Yaroslav Kuznietsov
3d7b01e28b
[Lens][TSVB] Ad-hoc dataViews for index pattern string mode in TSVB. ( #143500 )
...
## Summary
Completes part of https://github.com/elastic/kibana/issues/138236 .
Added support of ad-hoc dataViews while converting TSVB visualizations,
when index pattern string mode is turned on.
Co-authored-by: Uladzislau Lasitsa <vlad.lasitsa@gmail.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-11-09 17:41:36 +02:00
Joe Reuter
452b81f0e7
[Lens] Rearrange options ( #144891 )
...
Fixes https://github.com/elastic/kibana/issues/138075
## Group by this field
This PR moves the "Group by this field" below the field selector. I
renamed it to "Aggregate by this dimension first" (instead of field)
because it's more accurate - this isn't really about the field and also
a thing for the "Filters" function which doesn't have a field:
<img width="355" alt="Screenshot 2022-11-09 at 12 29 29"
src="https://user-images.githubusercontent.com/1508364/200818974-f5dc304f-2457-4604-8a0a-c94ed1d50b83.png ">
<img width="355" alt="Screenshot 2022-11-09 at 12 29 33"
src="https://user-images.githubusercontent.com/1508364/200818978-f48e42e8-f2df-43c8-8479-d6cac205fafa.png ">
<img width="353" alt="Screenshot 2022-11-09 at 12 29 38"
src="https://user-images.githubusercontent.com/1508364/200818983-2c00f8de-06ee-4d9a-82d6-14c161e0b91f.png ">
<img width="353" alt="Screenshot 2022-11-09 at 12 29 44"
src="https://user-images.githubusercontent.com/1508364/200818986-e76a6d88-a6a1-4897-8fad-f0d56027c1d1.png ">
Drive-by change: Move the "Include empty rows" up above the granularity
slider for intervals to match the date histogram order
## Collapse by
It also moves "Collapse by" into the data section (relevant for xy
breakdown, table rows and partition slices)
<img width="357" alt="Screenshot 2022-11-09 at 12 36 53"
src="https://user-images.githubusercontent.com/1508364/200820679-afb8e08b-a91b-46ef-8111-c09cfdb51865.png ">
<img width="353" alt="Screenshot 2022-11-09 at 12 36 59"
src="https://user-images.githubusercontent.com/1508364/200820682-4f416404-4693-46cd-80df-7c868deadc44.png ">
<img width="355" alt="Screenshot 2022-11-09 at 12 36 40"
src="https://user-images.githubusercontent.com/1508364/200820669-0fab52da-7fa1-4fff-b183-8d5c7e4695b9.png ">
<img width="360" alt="Screenshot 2022-11-09 at 12 36 46"
src="https://user-images.githubusercontent.com/1508364/200820675-837e3736-9519-42a6-98ca-9a9bae9840f1.png ">
Also works for text based:
<img width="360" alt="Screenshot 2022-11-09 at 12 47 08"
src="https://user-images.githubusercontent.com/1508364/200822518-e76dd9b5-df9f-4289-a468-0b63bfa1988c.png ">
## Technical details
For the collapse by part I had to add another form render hook to the
visualization `renderDimensionEditorDataExtra` which is passed to the
datasource dimension editor so it can be rendered in the right place. On
the datasource side the integration for text based is very straight
forward, for form based there are two flavors - just render below the
operation edit options or pass to the operation editor (used for terms)
2022-11-09 16:22:52 +01:00
Maryam Saeidi
ef7c1a689b
[Actionable Observability] Integrate alert search bar on rule details page ( #144718 )
...
Resolves #143962
## 📝 Summary
In this PR, an alerts search bar was added to the rule details page by
syncing its state to the URL. This will enable navigating to the alerts
table for a specific rule with a filtered state based on active or
recovered.
### Notes
- Renamed alert page container to alert search bar container and used it
both in alerts and rule details page (it will be responsible to sync
search bar params to the URL) --> moved to a shared component
- Moved AlertsStatusFilter to be a sub-component of the shared
observability search bar
- Allowed ObservabilityAlertSearchBar to be used both as a stand-alone
component and as a wired component with syncing params to the URL
(ObservabilityAlertSearchBar, ObservabilityAlertSearchbarWithUrlSync)
- Set a minHeight for the Alerts and Execution tab, otherwise, the page
will have extra scroll on the tab change while content is loading (very
annoying!)
## 🎨 Preview
## 🧪 How to test
- Create a rule and go to the rule details page
- Click on the alerts tab and change the search criteria, you should be
able to see the criteria in the query parameter
- Refresh the page, alerts tab should be selected and you should be able
to see the filters that you applied in the previous step
- As a side test, check alert search bar on alerts page as well, it
should work as before
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-11-09 16:18:16 +01:00
Devin W. Hurley
b1179e72ff
[Security Solution] [Exceptions] Adds options to create a shared exception list and to create a single item from the manage exceptions view ( #144575 )
...
Adds options to create a shared exception list and creating a single
item to be attached to multiple rules default lists or to add it to
shared lists.
Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-11-09 09:54:45 -05:00
Coen Warmer
9298023c1b
[Actionable Observability] Add context.alertDetailsUrl to connector template for Uptime > Monitor status & Uptime TLS rules ( #144740 )
...
Closes https://github.com/elastic/kibana/issues/144441
2022-11-09 07:50:45 -07:00
Jatin Kathuria
92d907cd93
[Security Solution] [Feat] Add Bulk Events to Timeline. ( #142737 )
...
This PR implements functionality to add multiple events to the timeline.
It is implements :
1. Selected events ( max 4000 ) can be added to the timeline.
## Implementation.
1. At present, it only support adding multiple records in the timeline
as `kql Filters`. https://github.com/elastic/kibana/pull/142436 is in
progress to implement `is-one-of` operator in the data provider. Once
that is moved to `main`, we can change value of `prefer` parameter to
send the IDs in `dataProvider` rather than filter.
If you would like to test it with
https://github.com/elastic/kibana/pull/142436 , please clone :
https://github.com/logeekal/kibana/tree/bulk_actions_add_timeline_with_is_one_of
2. Below is the demonstration how it works.
https://user-images.githubusercontent.com/7485038/199056731-4287fc61-9d0b-4cf3-ba1f-741f6b66ae97.mov
2022-11-09 07:48:12 -07:00
Luke Gmys
225156a40f
[TIP] Env specific cypress config ( #144894 )
...
## Summary
This tiny PR makes reduces the Cypress command timeout when run locally
for tighter feedback look while developing e2e tests locally.
2022-11-09 15:12:27 +01:00
Tiago Costa
c3f5b6aba5
skip flaky suite ( #144885 )
2022-11-09 14:08:57 +00:00
Efe Gürkan YALAMAN
b2e0035d34
[Enterprise Search] Fixes Search Index page to go blank when connection lost ( #144022 )
...
Previously when we lose connection to backend, Search Index page was
going blank. This PR prevents page to go blank, but rather show a flash
message.
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2022-11-09 06:28:44 -07:00
Or Ouziel
4469da8dfe
[Cloud Posture] track findings pages ( #144822 )
2022-11-09 15:08:03 +02:00
Sébastien Loix
2590173096
[ContentManagement] Inspector flyout ( #144240 )
2022-11-09 06:01:53 -07:00
Jordan
1ff9ceba69
[Cloud Posture] Dashboard Redesign - data counter cards ( #144565 )
2022-11-09 14:51:41 +02:00
Luke Gmys
f1be6057c8
[TIP] Run e2e pipeline on CI ( #144776 )
...
## Summary
Last week, our team has dicovered that e2e tests are not executed on CI,
this PR is an attempt to fix that.
Threat intel pipeline should be run whenever the `threat_intelligence`
plugin source or related tests config has changed.
2022-11-09 12:51:09 +01:00
Yulia Čech
9a47f41883
[Guided onboarding] Config updates for the Security guide ( #144844 )
...
## Summary
Fixes https://github.com/elastic/kibana/issues/138644
This PR adds a manual completion to the Alerts and fixes the link to
redirect the user to Dashboards as the end of the guide.
Screenshot
<img width="356" alt="Screenshot 2022-11-08 at 20 39 52"
src="https://user-images.githubusercontent.com/6585477/200661086-4724c584-a215-45a7-832e-961bed99600e.png ">
Screencast
https://user-images.githubusercontent.com/6585477/200661156-241d2ab3-47a0-465a-a59d-17d72ca53ccb.mov
Co-authored-by: Kelly Murphy <kelly.murphy@elastic.co>
2022-11-09 04:41:32 -07:00
Mike Côté
daf9322326
Cleanup unused code for claiming tasks by id ( #144408 )
...
In this PR, I'm cleaning up code within Task Manager regarding claiming
tasks by id that is no longer used. The code was previously used for
running alerting rules right away but recently `runNow` got replaced
with `runSoon` which no longer needs this code to function. For more
info on the previous change, see
https://github.com/elastic/kibana/issues/133550 .
2022-11-09 06:37:13 -05:00
Mike Côté
08eb63af67
Ping the response-ops team whenever a new connector type is registered ( #144736 )
...
Similar to https://github.com/elastic/kibana/pull/144196 and
https://github.com/elastic/kibana/pull/144424 .
In this PR, I'm making the Response Ops team get pinged whenever a new
connector type is added.
I also renamed two connector types in our test suite to keep the array
I'm asserting clean (from test connectors).
- `.test-sub-action-connector` -> `test.sub-action-connector`
- `.test-sub-action-connector-without-sub-actions` ->
`test.sub-action-connector-without-sub-actions`
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2022-11-09 06:35:57 -05:00
